---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123376/
---
(Updated Okt. 18, 2015, 2:02 nachm.)
Status
--
This change has been
> On Aug. 12, 2015, 10:17 vorm., Thomas Lübking wrote:
> > bump, we should get this fixed for 5.4
> >
> > Shui, do you want to work on improving the patch and adding the testcase?
>
> Thomas Lübking wrote:
> -100
> THE PATCH BREAKS BACKTABBING!!
>
> Btw. entirely not figured by
> On Mai 1, 2015, 7:51 vorm., Thomas Lübking wrote:
> > Two things.
> > a) "1" is a magic number (stupid xcb, should be xcppb ;-) - please add a
> > comment that this picks the 1st level shift
> > b) the overall code looks a bit inefficient. No idea how smart xcb is under
> > the hood, but
> >
> On Aug. 12, 2015, 10:17 vorm., Thomas Lübking wrote:
> > bump, we should get this fixed for 5.4
> >
> > Shui, do you want to work on improving the patch and adding the testcase?
>
> Thomas Lübking wrote:
> -100
> THE PATCH BREAKS BACKTABBING!!
>
> Btw. entirely not figured by
> On Aug. 12, 2015, 10:17 a.m., Thomas Lübking wrote:
> > bump, we should get this fixed for 5.4
> >
> > Shui, do you want to work on improving the patch and adding the testcase?
>
> Thomas Lübking wrote:
> -100
> THE PATCH BREAKS BACKTABBING!!
>
> Btw. entirely not figured by
> On May 1, 2015, 7:51 a.m., Thomas Lübking wrote:
> > Two things.
> > a) "1" is a magic number (stupid xcb, should be xcppb ;-) - please add a
> > comment that this picks the 1st level shift
> > b) the overall code looks a bit inefficient. No idea how smart xcb is under
> > the hood, but
> >
> On Aug. 12, 2015, 10:17 vorm., Thomas Lübking wrote:
> > bump, we should get this fixed for 5.4
> >
> > Shui, do you want to work on improving the patch and adding the testcase?
>
> Thomas Lübking wrote:
> -100
> THE PATCH BREAKS BACKTABBING!!
>
> Btw. entirely not figured by
> On Aug. 12, 2015, 10:17 vorm., Thomas Lübking wrote:
> > bump, we should get this fixed for 5.4
> >
> > Shui, do you want to work on improving the patch and adding the testcase?
-100
THE PATCH BREAKS BACKTABBING!!
Btw. entirely not figured by autotests :-P
@Martin
test might be quite a prob
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123376/#review83734
---
bump, we should get this fixed for 5.4
Shui, do you want to w
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123376/#review79753
---
Two things.
a) "1" is a magic number (stupid xcb, should be xc
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123376/#review79026
---
would you mind adding a testcase for it?
- Martin Gräßlin
O
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123376/
---
Review request for KDE Frameworks.
Bugs: 341959
https://bugs.kde.org/
12 matches
Mail list logo
