Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/ --- (Updated Jan. 21, 2017, 12:46 a.m.) Status -- This change has been d

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

> On Oct. 19, 2015, 6:50 p.m., Rex Dieter wrote: > > May as well drop this now, it's largely superceded by code in in repo > > already, for example, > > https://quickgit.kde.org/?p=sonnet.git&a=commit&h=0e6edac621fbd366b126ebd851fbea21355e02d0 Dropping as suggested by Rex. - Albert ---

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/#review87098 --- May as well drop this now, it's largely superceded by code in

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/#review83458 --- Ship it! This is the obvious easy fix (I was about to submit

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

> On April 7, 2015, 1:44 a.m., Aleix Pol Gonzalez wrote: > > This doesn't let the user change the path but the distributor, that's quite > > a different thing. Maybe it should be a runtime check? Ideally yes, but the approach taken here so far is at least an incremental improvement over the st

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/ --- (Updated April 27, 2015, 3:30 p.m.) Review request for KDE Frameworks and

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/ --- (Updated Квітень 7, 2015, 2:20 після полудня) Review request for KDE Fram

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

> On March 17, 2015, 6:05 p.m., Christophe Giboudeaux wrote: > > src/plugins/hunspell/CMakeLists.txt, line 9 > > > > > > endif() > > Eugene Shalygin wrote: > Ping? He means you shouldn't put anything inside e

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/#review78586 --- This doesn't let the user change the path but the distributor,

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

> On Березень 17, 2015, 6:05 після полудня, Christophe Giboudeaux wrote: > > src/plugins/hunspell/CMakeLists.txt, line 9 > > > > > > endif() Ping? - Eugene -

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

> On Березень 17, 2015, 2:07 після полудня, Laurent Montel wrote: > > src/plugins/hunspell/hunspellclient.cpp, line 27 > > > > > > #include "..." > > we use local file. > > Rolf Eike Beer wrote: > No, the

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

> On März 17, 2015, 1:07 nachm., Laurent Montel wrote: > > src/plugins/hunspell/hunspellclient.cpp, line 27 > > > > > > #include "..." > > we use local file. No, the file is in an include path, not in the sam

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

> On Березень 17, 2015, 6:05 після полудня, Christophe Giboudeaux wrote: > > src/plugins/hunspell/CMakeLists.txt, line 7 > > > > > > So you change an hardcoded path by a user chosen hardcoded one ? > > > >

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/#review77647 --- src/plugins/hunspell/CMakeLists.txt

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/#review77636 --- Ok for me. Just wait that maintainer gives you a "Ship it" -

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/ --- (Updated Березень 17, 2015, 2:09 після полудня) Review request for KDE Fr

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/#review77630 --- src/plugins/hunspell/hunspellclient.cpp

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/#review77631 --- I am not maintainer of this module but I can put a "+1" - Lau

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

> On Березень 17, 2015, 1:41 після полудня, Luigi Toscano wrote: > > (not entitled to give a ship it, but) have you checked if this is still > > relevant for the Sonnet framework? > > Luigi Toscano wrote: > Ups, this review is for sonnet; I was confused by the group (please use > kdeframew

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/ --- (Updated Березень 17, 2015, 2:05 після полудня) Review request for KDE Fr

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/ --- (Updated Березень 17, 2015, 1:50 після полудня) Review request for KDE Fr

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987/ --- (Updated Березень 17, 2015, 1:50 після полудня) Review request for KDE Fr