Re: Review Request 122926: Add setError method to JobViewV2 interface

2015-03-15 Thread Albert Astals Cid
> On mar. 15, 2015, 11:10 a.m., Bhushan Shah wrote: > > Umm; this seems to break source compatibilty maybe? For example > > plasma-workspace Plasma/5.2 branch which compiled with older revisions fine > > seems to fail with this commit > > > > 23:07:43 Building CXX object > > applets/systemtra

Re: Review Request 122926: Add setError method to JobViewV2 interface

2015-03-15 Thread David Rosca
> On March 15, 2015, 11:10 a.m., Bhushan Shah wrote: > > Umm; this seems to break source compatibilty maybe? For example > > plasma-workspace Plasma/5.2 branch which compiled with older revisions fine > > seems to fail with this commit > > > > 23:07:43 Building CXX object > > applets/systemtr

Re: Review Request 122926: Add setError method to JobViewV2 interface

2015-03-15 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122926/#review77503 --- Umm; this seems to break source compatibilty maybe? For exampl

Re: Review Request 122926: Add setError method to JobViewV2 interface

2015-03-13 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122926/ --- (Updated March 13, 2015, 7:26 p.m.) Status -- This change has been m

Re: Review Request 122926: Add setError method to JobViewV2 interface

2015-03-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122926/#review77407 --- Ship it! OK. This could have been part of the terminate call,

Review Request 122926: Add setError method to JobViewV2 interface

2015-03-12 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122926/ --- Review request for KDE Frameworks. Repository: kjobwidgets Description