Re: Review Request 122408: allow to cycle through activities from global shortcuts plugin

2015-02-23 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122408/ --- (Updated Feb. 24, 2015, 12:32 p.m.) Status -- This change has been d

Re: Review Request 122408: allow to cycle through activities from global shortcuts plugin

2015-02-05 Thread Bhushan Shah
> On Feb. 3, 2015, 11:10 p.m., Ivan Čukić wrote: > > This does fix the switching, but I don't agree it is the right place for it > > (I don't like that this plugin exists at all tbh). > > > > When switching the activities, there needs to be a (UI) feedback - the > > switcher needs to show up.

Re: Review Request 122408: allow to cycle through activities from global shortcuts plugin

2015-02-03 Thread Ivan Čukić
> On Feb. 3, 2015, 5:40 p.m., Ivan Čukić wrote: > > This does fix the switching, but I don't agree it is the right place for it > > (I don't like that this plugin exists at all tbh). > > > > When switching the activities, there needs to be a (UI) feedback - the > > switcher needs to show up. T

Re: Review Request 122408: allow to cycle through activities from global shortcuts plugin

2015-02-03 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122408/#review75324 --- This does fix the switching, but I don't agree it is the right

Re: Review Request 122408: allow to cycle through activities from global shortcuts plugin

2015-02-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122408/#review75322 --- to me is fine to have it either done by the plasmashell or act

Review Request 122408: allow to cycle through activities from global shortcuts plugin

2015-02-03 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122408/ --- Review request for KDE Frameworks, Plasma and Ivan Čukić. Bugs: 342186