Re: Review Request 121093: Revert "don't recompile exported classes, link to their dll"

2014-11-10 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/ --- (Updated Nov. 10, 2014, 2:36 p.m.) Status -- This change has been ma

Re: Review Request 121093: Revert "don't recompile exported classes, link to their dll"

2014-11-10 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/#review70191 --- Ship it! Ship It! - Patrick von Reth On Nov. 10, 2014, 2:2

Re: Review Request 121093: Revert "don't recompile exported classes, link to their dll"

2014-11-10 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/ --- (Updated Nov. 10, 2014, 2:23 p.m.) Review request for KDE Frameworks, Alb

Re: Review Request 121093: Revert "don't recompile exported classes, link to their dll"

2014-11-10 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/ --- (Updated Nov. 10, 2014, 2:22 p.m.) Review request for KDE Frameworks and

Re: Review Request 121093: Revert "don't recompile exported classes, link to their dll"

2014-11-10 Thread Milian Wolff
> On Nov. 10, 2014, 2:05 p.m., Patrick von Reth wrote: > > Yes as the files include export macros compiling them into an another > > lib/exe will break the build. > > As those where already part of a dll I thought I could just link the dll. I > > tested it on Windows and it build fine. > > What

Re: Review Request 121093: Revert "don't recompile exported classes, link to their dll"

2014-11-10 Thread Patrick von Reth
> On Nov. 10, 2014, 2:05 p.m., Patrick von Reth wrote: > > Yes as the files include export macros compiling them into an another > > lib/exe will break the build. > > As those where already part of a dll I thought I could just link the dll. I > > tested it on Windows and it build fine. > > What

Re: Review Request 121093: Revert "don't recompile exported classes, link to their dll"

2014-11-10 Thread Milian Wolff
> On Nov. 10, 2014, 2:05 p.m., Patrick von Reth wrote: > > Yes as the files include export macros compiling them into an another > > lib/exe will break the build. > > As those where already part of a dll I thought I could just link the dll. I > > tested it on Windows and it build fine. > > What

Re: Review Request 121093: Revert "don't recompile exported classes, link to their dll"

2014-11-10 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/#review70185 --- Yes as the files include export macros compiling them into an

Review Request 121093: Revert "don't recompile exported classes, link to their dll"

2014-11-10 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/ --- Review request for KDE Frameworks, Albert Astals Cid, Patrick von Reth, and