Re: Review Request 119798: Generating PkgConig files from ECM

> On Aug. 15, 2014, 8:20 a.m., Alex Merry wrote: > > modules/ECMGeneratePkgConfigFile.cmake, line 47 > > > > > > This belongs in KDEInstallDirs.cmake, not here (as > > CMAKE_INSTALL_PKGCONFIGDIR, ideally). Projec

Re: Review Request 119798: Generating PkgConig files from ECM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/#review64807 --- modules/ECMGeneratePkgConfigFile.cmake

Re: Review Request 119798: Generating PkgConig files from ECM

> On Aug. 15, 2014, 8:20 a.m., Alex Merry wrote: > > modules/ECMGeneratePkgConfigFile.cmake, lines 25-26 > > > > > > Why not have both be KF5Archive as the standard? And have LIB_NAME > > default to BASE_NAME (or

Re: Review Request 119798: Generating PkgConig files from ECM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/ --- (Updated Aug. 18, 2014, 1:59 p.m.) Review request for Build System, KDE F

Re: Review Request 119798: Generating PkgConig files from ECM

> On Aug. 15, 2014, 8:20 a.m., Alex Merry wrote: > > modules/ECMGeneratePkgConfigFile.cmake, lines 25-26 > > > > > > Why not have both be KF5Archive as the standard? And have LIB_NAME > > default to BASE_NAME (or

Re: Review Request 119798: Generating PkgConig files from ECM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/#review64585 --- I'm in favour of this - I was planning to do it myself before

Re: Review Request 119798: Generating PkgConig files from ECM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/#review64581 --- +1 - Harald Sitter On Aug. 14, 2014, 11:10 p.m., Aleix Pol

Review Request 119798: Generating PkgConig files from ECM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/ --- Review request for Build System, KDE Frameworks and Harald Sitter. Reposi