Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

2014-05-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/#review58144 --- This review has been submitted with commit c5c34851dc410aa146

Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

2014-05-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/ --- (Updated May 19, 2014, 12:07 p.m.) Status -- This change has been ma

Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

2014-05-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/#review58142 --- Ship it! Ship It! - Marco Martin On May 19, 2014, 10:56 a.

Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

2014-05-19 Thread Martin Gräßlin
> On May 19, 2014, 1:06 p.m., Marco Martin wrote: > > looks fine. > > can you try it also on an item that uses dbusmenu for menus, like kmix? I just tried kmix and it looks fine to me on both left and right click. Both menus behave like I would expect (override redirect, grabbing pointer/keyboa

Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

2014-05-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/#review58139 --- looks fine. can you try it also on an item that uses dbusmenu

Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

2014-05-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: k