Re: Review Request 117146: Remove unused dependencies

2014-03-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117146/#review54602 --- This review has been submitted with commit 7786630bdc8898fb69

Re: Review Request 117146: Remove unused dependencies

2014-03-30 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117146/ --- (Updated March 30, 2014, 2:03 p.m.) Status -- This change has been m

Re: Review Request 117146: Remove unused dependencies

2014-03-29 Thread Michael Palimaka
> On March 29, 2014, 12:02 a.m., Aleix Pol Gonzalez wrote: > > src/kdeui/kglobalsettings.cpp, line 61 > > > > > > Why comment it? We either need it or don't need it... I did this so that it's "there but not there

Re: Review Request 117146: Remove unused dependencies

2014-03-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117146/#review54518 --- Ship it! Besides the small detail, looks good to me. src/kd

Review Request 117146: Remove unused dependencies

2014-03-28 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117146/ --- Review request for KDE Frameworks. Repository: kde4support Description