Re: Review Request 117131: Implement KUser::faceIconPath on Windows.

2014-04-04 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117131/ --- (Updated April 5, 2014, 1:32 a.m.) Status -- This change has been ma

Re: Review Request 117131: Implement KUser::faceIconPath on Windows.

2014-04-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117131/#review55008 --- This review has been submitted with commit c35ece00babf9a2ee0

Re: Review Request 117131: Implement KUser::faceIconPath on Windows.

2014-04-04 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117131/#review54998 --- Ship it! Ship It! src/lib/util/kuser_win.cpp

Re: Review Request 117131: Implement KUser::faceIconPath on Windows.

2014-03-30 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117131/ --- (Updated March 30, 2014, 12:35 p.m.) Review request for KDE Frameworks an

Re: Review Request 117131: Implement KUser::faceIconPath on Windows.

2014-03-30 Thread Nicolás Alvarez
> On March 28, 2014, 10:49 a.m., Alexander Richardson wrote: > > src/lib/util/kuser_win.cpp, line 391 > > > > > > WCHAR pathBuf[MAX_PATH]; > > > > then you don't need the reinterpret_cast and can use >

Re: Review Request 117131: Implement KUser::faceIconPath on Windows.

2014-03-28 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117131/#review54437 --- I would personally keep the fallback code in case we couldn't

Review Request 117131: Implement KUser::faceIconPath on Windows.

2014-03-27 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117131/ --- Review request for KDE Frameworks and kdewin. Repository: kcoreaddons D