Re: Review Request 115715: Remove X11 dependency from kprintutils

2014-02-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115715/#review51328 --- This review has been submitted with commit c0a9f41328df263f4e

Re: Review Request 115715: Remove X11 dependency from kprintutils

2014-02-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115715/#review50011 --- This review has been submitted with commit c0a9f41328df263f4e

Re: Review Request 115715: Remove X11 dependency from kprintutils

2014-02-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115715/ --- (Updated Feb. 17, 2014, 7:19 a.m.) Status -- This change has been ma

Re: Review Request 115715: Remove X11 dependency from kprintutils

2014-02-15 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115715/#review49828 --- Ship it! Ship It! - John Layt On Feb. 15, 2014, 12:37 p.m.

Re: Review Request 115715: Remove X11 dependency from kprintutils

2014-02-15 Thread John Layt
> On Feb. 14, 2014, 1:58 p.m., John Layt wrote: > > I'd prefer for now that you just replace the HAVE_X11 with "#defined > > Q_OS_UNIX && !defined Q_OS_MAC" which should produce the same effect. No > > point in compiling the CUPS code if we're never going to use it. Once Qt > > feature freez

Re: Review Request 115715: Remove X11 dependency from kprintutils

2014-02-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115715/ --- (Updated Feb. 15, 2014, 1:37 p.m.) Review request for KDE Frameworks, kde

Re: Review Request 115715: Remove X11 dependency from kprintutils

2014-02-14 Thread Nicolás Alvarez
> On Feb. 14, 2014, 10:58 a.m., John Layt wrote: > > I'd prefer for now that you just replace the HAVE_X11 with "#defined > > Q_OS_UNIX && !defined Q_OS_MAC" which should produce the same effect. No > > point in compiling the CUPS code if we're never going to use it. Once Qt > > feature free

Re: Review Request 115715: Remove X11 dependency from kprintutils

2014-02-14 Thread John Layt
> On Feb. 14, 2014, 1:58 p.m., John Layt wrote: > > I'd prefer for now that you just replace the HAVE_X11 with "#defined > > Q_OS_UNIX && !defined Q_OS_MAC" which should produce the same effect. No > > point in compiling the CUPS code if we're never going to use it. Once Qt > > feature freez

Re: Review Request 115715: Remove X11 dependency from kprintutils

2014-02-14 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115715/#review49783 --- I'd prefer for now that you just replace the HAVE_X11 with "#d

Review Request 115715: Remove X11 dependency from kprintutils

2014-02-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115715/ --- Review request for KDE Frameworks, kdewin and John Layt. Repository: kpri