Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-21 Thread Hrvoje Senjan
> On Feb. 20, 2014, 12:56 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 4fbbc75429597dc545ae8af24e870d9bac5f2f2a by Alex Merry to branch master. Seems Qt 5.3 will have it's own webp plugin (commit 4522b350e53471c2ebc6d4692736ee4708445b66 in stable branch)... - H

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-20 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/ --- (Updated Feb. 20, 2014, 12:56 p.m.) Status -- This change has been m

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/#review50360 --- This review has been submitted with commit 331a813662e5b753bc

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/#review50359 --- This review has been submitted with commit 30cff602964dd47379

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/#review50361 --- This review has been submitted with commit 4fbbc75429597dc545

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/#review50358 --- This review has been submitted with commit 71772963359553c2da

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-20 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/#review50351 --- Ship it! I think it addresses all previous comments and I don

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/ --- (Updated Feb. 16, 2014, 12:14 p.m.) Review request for KDE Frameworks.

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-16 Thread David Faure
> On Feb. 15, 2014, 10:33 p.m., David Faure wrote: > > src/imageformats/CMakeLists.txt, line 137 > > > > > > don't you mean removing the whole use of find_package(SharedMimeInfo), > > once we can depend on smi 1

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-16 Thread Alex Merry
> On Feb. 15, 2014, 10:33 p.m., David Faure wrote: > > src/imageformats/CMakeLists.txt, line 137 > > > > > > don't you mean removing the whole use of find_package(SharedMimeInfo), > > once we can depend on smi 1

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/#review49881 --- Looks good to me. Just some minor comments. src/imageformats

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-14 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/ --- (Updated Feb. 14, 2014, 2:10 p.m.) Review request for KDE Frameworks. C

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-14 Thread Alex Merry
> On Feb. 14, 2014, 12:26 a.m., Alexander Richardson wrote: > > cmake/FindSharedMimeInfo.cmake, line 1 > > > > > > This file is also needed by kcoreaddons (and I would also need it for > > okteta, currently the mi

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/#review49762 --- cmake/FindSharedMimeInfo.cmake

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/ --- (Updated Feb. 12, 2014, 11:03 a.m.) Review request for KDE Frameworks.

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-02-05 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/ --- (Updated Feb. 5, 2014, 3:31 p.m.) Review request for KDE Frameworks and A

Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/ --- Review request for KDE Frameworks and Alex Merry. Repository: kimageforma

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

2014-01-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/ --- (Updated Jan. 28, 2014, 2:57 p.m.) Review request for KDE Frameworks. R