Re: Review Request 115157: Make better use of KWindowSystem in KPassivePopup

2014-01-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115157/ --- (Updated Jan. 21, 2014, 12:24 p.m.) Status -- This change has been m

Re: Review Request 115157: Make better use of KWindowSystem in KPassivePopup

2014-01-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115157/#review47861 --- This review has been submitted with commit 096faf3d2bf7786bbc

Re: Review Request 115157: Make better use of KWindowSystem in KPassivePopup

2014-01-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115157/#review47860 --- Ship it! Ship It! - Martin Gräßlin On Jan. 20, 2014, 6:58

Re: Review Request 115157: Make better use of KWindowSystem in KPassivePopup

2014-01-21 Thread Alex Merry
> On Jan. 21, 2014, 6:42 a.m., Martin Gräßlin wrote: > > src/kpassivepopup.cpp, lines 466-467 > > > > > > small suggestion: > > if (QWidget *widget = QWidget::find(d->window)) { > > ... > > } I have

Re: Review Request 115157: Make better use of KWindowSystem in KPassivePopup

2014-01-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115157/#review47854 --- Thanks for pointing out issues in KWindowSystem. I do hope tha

Review Request 115157: Make better use of KWindowSystem in KPassivePopup

2014-01-20 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115157/ --- Review request for KDE Frameworks, Martin Gräßlin and Michael Palimaka. R