Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

2014-01-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115123/ --- (Updated Jan. 27, 2014, 12:26 p.m.) Status -- This change has been m

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

2014-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115123/#review48375 --- This review has been submitted with commit b2083df231dd7c6cdb

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

2014-01-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115123/#review48339 --- Ship it! Ship It! - Kevin Ottens On Jan. 19, 2014, 3:49 p.

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

2014-01-26 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115123/#review48307 --- I'll commit this if there are no objections in the next couple

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

2014-01-19 Thread Alex Merry
> On Jan. 19, 2014, 5:21 p.m., Stephen Kelly wrote: > > cmake/FindOpenEXR.cmake, line 26 > > > > > > What is in PC_OpenEXR_CFLAGS_OTHER ? > > > > INTERFACE_COMPILE_DEFINITIONS is only suitable for compile

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

2014-01-19 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115123/#review47714 --- cmake/FindOpenEXR.cmake

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

2014-01-19 Thread Alex Merry
> On Jan. 19, 2014, 2:34 p.m., Stephen Kelly wrote: > > cmake/FindOpenEXR.cmake, line 110 > > > > > > I would simply add a fatal_error if cmake version is VERSION_LESS > > 2.8.12, and remove the rest of this ver

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

2014-01-19 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115123/ --- (Updated Jan. 19, 2014, 3:49 p.m.) Review request for KDE Frameworks and

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

2014-01-19 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115123/ --- (Updated Jan. 19, 2014, 3:39 p.m.) Review request for KDE Frameworks and

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

2014-01-19 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115123/#review47698 --- Makes a lot of sense to me, yep. cmake/FindOpenEXR.cmake

Review Request 115123: Add an imported target to FindOpenEXR.cmake

2014-01-19 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115123/ --- Review request for KDE Frameworks and Stephen Kelly. Repository: kimagefo