Re: Review Request 115016: Make KJob usable from QML

2014-01-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115016/#review47489 --- This review has been submitted with commit 08f24ddc85bd6c6409

Re: Review Request 115016: Make KJob usable from QML

2014-01-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115016/ --- (Updated Jan. 16, 2014, 11:06 a.m.) Status -- This change has been m

Re: Review Request 115016: Make KJob usable from QML

2014-01-16 Thread Aurélien Gâteau
On Wed, Jan 15, 2014, at 4:43, Kevin Krammer wrote: > On Tuesday, 2014-01-14, 23:12:56, Aurélien Gâteau wrote: > > > On Jan. 14, 2014, 9:20 p.m., Alex Merry wrote: > > > > src/lib/jobs/kjob.h, line 92 > > > > > > > line92>>

Re: Review Request 115016: Make KJob usable from QML

2014-01-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115016/#review47440 --- Ship it! After Kevin Krammer's comment on the list, I realise

Re: Review Request 115016: Make KJob usable from QML

2014-01-15 Thread Alex Merry
On 15/01/14 12:43, Kevin Krammer wrote: > On Tuesday, 2014-01-14, 23:12:56, Aurélien Gâteau wrote: >> A NOTIFY signal is optional. If defined, it should specify one existing >> signal in that class that is emitted whenever the value of the property >> changes. NOTIFY signals for MEMBER variables mu

Re: Review Request 115016: Make KJob usable from QML

2014-01-15 Thread Kevin Krammer
On Tuesday, 2014-01-14, 23:12:56, Aurélien Gâteau wrote: > > On Jan. 14, 2014, 9:20 p.m., Alex Merry wrote: > > > src/lib/jobs/kjob.h, line 92 > > > > > line92>> > > > > I don't think this will work; I'm fairly sure tha

Re: Review Request 115016: Make KJob usable from QML

2014-01-14 Thread Aurélien Gâteau
> On Jan. 14, 2014, 9:20 p.m., Alex Merry wrote: > > src/lib/jobs/kjob.h, line 92 > > > > > > I don't think this will work; I'm fairly sure that notify signals must > > have zero or one arguments, and the one arg

Re: Review Request 115016: Make KJob usable from QML

2014-01-14 Thread Aleix Pol Gonzalez
> On Jan. 14, 2014, 8:20 p.m., Alex Merry wrote: > > src/lib/jobs/kjob.h, line 92 > > > > > > I don't think this will work; I'm fairly sure that notify signals must > > have zero or one arguments, and the one arg

Re: Review Request 115016: Make KJob usable from QML

2014-01-14 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115016/#review47395 --- src/lib/jobs/kjob.h

Review Request 115016: Make KJob usable from QML

2014-01-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115016/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description