Re: Review Request 113516: Implement queueing directly in KDialogJobUiDelegate

2013-11-05 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113516/ --- (Updated Nov. 5, 2013, 11:23 a.m.) Status -- This change has been mar

Re: Review Request 113516: Implement queueing directly in KDialogJobUiDelegate

2013-11-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113516/#review43047 --- This review has been submitted with commit efbf655b7ab548a0bcc

Re: Review Request 113516: Implement queueing directly in KDialogJobUiDelegate

2013-11-05 Thread Àlex Fiestas
> On Nov. 2, 2013, 1:42 p.m., Alex Merry wrote: > > tier2/kjobwidgets/src/kdialogjobuidelegate.cpp, line 79 > > > > > > This will be application model, I believe. Might be worth mentioning > > the class apidocs (

Re: Review Request 113516: Implement queueing directly in KDialogJobUiDelegate

2013-11-05 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113516/ --- (Updated Nov. 5, 2013, 11:04 a.m.) Review request for KDE Frameworks. Re

Re: Review Request 113516: Implement queueing directly in KDialogJobUiDelegate

2013-11-05 Thread Àlex Fiestas
> On Nov. 2, 2013, 1:42 p.m., Alex Merry wrote: > > tier2/kjobwidgets/src/kdialogjobuidelegate.cpp, lines 73-76 > > > > > > Would it not be marginally more efficient (and still correct) to put > > this test at the

Re: Review Request 113516: Implement queueing directly in KDialogJobUiDelegate

2013-11-04 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113516/#review42956 --- Small nitpick, otherwise looks fine. tier2/kjobwidgets/src/kd

Re: Review Request 113516: Implement queueing directly in KDialogJobUiDelegate

2013-11-02 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113516/#review42831 --- Ship it! Generally looks good, but see the comments below. Al

Review Request 113516: Implement queueing directly in KDialogJobUiDelegate

2013-10-31 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113516/ --- Review request for KDE Frameworks. Repository: kdelibs Description -