Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-29 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/ --- (Updated Oct. 29, 2013, 1:12 p.m.) Status -- This change has been mar

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/#review42632 --- This review has been submitted with commit 7582c2b341c97362aab

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-29 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/#review42576 --- Ship it! Ship It! - Kevin Ottens On Oct. 21, 2013, 1:32 p.m

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-21 Thread Aurélien Gâteau
> On Oct. 21, 2013, 1:43 p.m., Kevin Ottens wrote: > > tier2/kdoctools/CMakeLists.txt, line 18 > > > > > > FOOBAR really? :-) > > > > In fact ecm_setup_version might not even be needed for that one, it has

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-21 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/ --- (Updated Oct. 21, 2013, 3:32 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/#review42080 --- tier2/kdoctools/CMakeLists.txt

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-18 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/ --- (Updated Oct. 18, 2013, 5:42 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-18 Thread Aurélien Gâteau
> On Oct. 18, 2013, 5:23 p.m., Aleix Pol Gonzalez wrote: > > tier2/kdoctools/CMakeLists.txt, line 30 > > > > > > The KF5 find_package should be outside of the if Oh right, should update the template as well then.

Re: Review Request 113328: Fix standalone build of kdoctools

2013-10-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/#review41951 --- tier2/kdoctools/CMakeLists.txt

Review Request 113328: Fix standalone build of kdoctools

2013-10-18 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/ --- Review request for KDE Frameworks. Repository: kdelibs Description -