Re: Review Request 113158: Implement queueing directly in KDialogJobUiDelegate

2013-11-03 Thread Kevin Ottens
> On Oct. 14, 2013, 9:05 a.m., Kevin Ottens wrote: > > I'm not sold on bastardizing QErrorMessage for that feature. The intent was > > more to have some code similar to what KDialogQueue (moved to KDE4Support) > > was doing directly in KDialogJobUiDelegate implementation. > > David Faure wrote

Re: Review Request 113158: Implement queueing directly in KDialogJobUiDelegate

2013-11-01 Thread David Faure
> On Oct. 14, 2013, 9:05 a.m., Kevin Ottens wrote: > > I'm not sold on bastardizing QErrorMessage for that feature. The intent was > > more to have some code similar to what KDialogQueue (moved to KDE4Support) > > was doing directly in KDialogJobUiDelegate implementation. I'm surprised by this

Re: Review Request 113158: Implement queueing directly in KDialogJobUiDelegate

2013-10-31 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113158/ --- (Updated Oct. 31, 2013, 10:15 a.m.) Status -- This change has been di

Re: Review Request 113158: Implement queueing directly in KDialogJobUiDelegate

2013-10-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113158/#review41683 --- I'm not sold on bastardizing QErrorMessage for that feature. Th

Re: Review Request 113158: Implement queueing directly in KDialogJobUiDelegate

2013-10-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113158/#review41578 --- You should import the test app into kio/tests (and possibly men

Review Request 113158: Implement queueing directly in KDialogJobUiDelegate

2013-10-07 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113158/ --- Review request for KDE Frameworks. Repository: kdelibs Description -