Re: Review Request 112896: Rework NETWM classes

2013-11-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112896/#review43888 --- This review has been submitted with commit d981e6e6be947a3e977

Re: Review Request 112896: Rework NETWM classes

2013-11-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112896/ --- (Updated Nov. 18, 2013, 1:21 p.m.) Status -- This change has been mar

Re: Review Request 112896: Rework NETWM classes

2013-11-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112896/ --- (Updated Nov. 8, 2013, 4:14 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 112896: Rework NETWM classes

2013-11-04 Thread Kevin Ottens
> On Sept. 26, 2013, 2:27 a.m., Fredrik Höglund wrote: > > I'm just going to point out something I know you already know since we've > > discussed it many times; > > that an xcb port of the NETWM classes already exists in a branch. > > Martin Gräßlin wrote: > my aim was to write the unit te

Re: Review Request 112896: Rework NETWM classes

2013-10-21 Thread Kevin Ottens
> On Sept. 26, 2013, 2:27 a.m., Fredrik Höglund wrote: > > I'm just going to point out something I know you already know since we've > > discussed it many times; > > that an xcb port of the NETWM classes already exists in a branch. > > Martin Gräßlin wrote: > my aim was to write the unit te

Re: Review Request 112896: Rework NETWM classes

2013-10-09 Thread Kevin Ottens
> On Sept. 26, 2013, 2:27 a.m., Fredrik Höglund wrote: > > I'm just going to point out something I know you already know since we've > > discussed it many times; > > that an xcb port of the NETWM classes already exists in a branch. > > Martin Gräßlin wrote: > my aim was to write the unit te

Re: Review Request 112896: Rework NETWM classes

2013-09-27 Thread Martin Gräßlin
> On Sept. 26, 2013, 4:27 a.m., Fredrik Höglund wrote: > > I'm just going to point out something I know you already know since we've > > discussed it many times; > > that an xcb port of the NETWM classes already exists in a branch. > > Martin Gräßlin wrote: > my aim was to write the unit te

Re: Review Request 112896: Rework NETWM classes

2013-09-26 Thread Fredrik Höglund
> On Sept. 26, 2013, 2:27 a.m., Fredrik Höglund wrote: > > I'm just going to point out something I know you already know since we've > > discussed it many times; > > that an xcb port of the NETWM classes already exists in a branch. > > Martin Gräßlin wrote: > my aim was to write the unit te

Re: Review Request 112896: Rework NETWM classes

2013-09-25 Thread Martin Gräßlin
> On Sept. 26, 2013, 4:27 a.m., Fredrik Höglund wrote: > > I'm just going to point out something I know you already know since we've > > discussed it many times; > > that an xcb port of the NETWM classes already exists in a branch. my aim was to write the unit test and that was the big junk of

Re: Review Request 112896: Rework NETWM classes

2013-09-25 Thread Fredrik Höglund
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112896/#review40840 --- I'm just going to point out something I know you already know s

Review Request 112896: Rework NETWM classes

2013-09-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112896/ --- Review request for KDE Frameworks. Description --- This is a patch se