Re: Review Request 112880: Added KColorSchemeToken class.

2013-12-04 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Dec. 4, 2013, 7:32 p.m.) Status -- This change has been disc

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-29 Thread Denis Kuplyakov
> On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: > > To get in this patch would benefit from being based on the frameworks > > branch and go into kdeclarative. > > Kevin Ottens wrote: > Any chance for an update? > > Denis Kuplyakov wrote: > Yes I will finish it, when have time. Ther

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-28 Thread Kevin Ottens
> On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: > > To get in this patch would benefit from being based on the frameworks > > branch and go into kdeclarative. > > Kevin Ottens wrote: > Any chance for an update? > > Denis Kuplyakov wrote: > Yes I will finish it, when have time. Ther

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-28 Thread Denis Kuplyakov
> On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: > > To get in this patch would benefit from being based on the frameworks > > branch and go into kdeclarative. > > Kevin Ottens wrote: > Any chance for an update? > > Denis Kuplyakov wrote: > Yes I will finish it, when have time. Ther

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-28 Thread Kevin Ottens
> On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: > > To get in this patch would benefit from being based on the frameworks > > branch and go into kdeclarative. > > Kevin Ottens wrote: > Any chance for an update? > > Denis Kuplyakov wrote: > Yes I will finish it, when have time. Ther

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-25 Thread Kevin Ottens
> On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: > > To get in this patch would benefit from being based on the frameworks > > branch and go into kdeclarative. > > Kevin Ottens wrote: > Any chance for an update? > > Denis Kuplyakov wrote: > Yes I will finish it, when have time. Ther

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-10 Thread Denis Kuplyakov
> On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: > > To get in this patch would benefit from being based on the frameworks > > branch and go into kdeclarative. > > Kevin Ottens wrote: > Any chance for an update? Yes I will finish it, when have time. There are many pre-exams in universit

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-10 Thread Kevin Ottens
> On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: > > To get in this patch would benefit from being based on the frameworks > > branch and go into kdeclarative. Any chance for an update? - Kevin --- This is an automatically generated

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review42069 --- To get in this patch would benefit from being based on the fram

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-09 Thread Denis Kuplyakov
> On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote: > > kdeui/colors/kcolorschemetoken.h, line 70 > > > > > > using int here loses the type-safety. Why no use the corresponding > > enums? It would also make the

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-09 Thread Kevin Ottens
> On Sept. 24, 2013, 6:55 a.m., Kevin Ottens wrote: > > I'm not sure we can let that in for kdelibs 4.x / kdeui... David? Any > > opinion? > > > > If we ignore that point for the moment, and think in terms of KF5, ATM it > > would go with KColorScheme in KConfigWidgets. I'm not quite sold on t

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-09 Thread Kevin Ottens
> On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote: > > kdeui/colors/kcolorschemetoken.h, line 70 > > > > > > using int here loses the type-safety. Why no use the corresponding > > enums? It would also make the

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-09 Thread Denis Kuplyakov
> On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote: > > kdeui/colors/kcolorschemetoken.h, line 70 > > > > > > using int here loses the type-safety. Why no use the corresponding > > enums? It would also make the

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-08 Thread Sebastian Kügler
> On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote: > > kdeui/colors/kcolorschemetoken.h, line 70 > > > > > > using int here loses the type-safety. Why no use the corresponding > > enums? It would also make the

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-08 Thread Denis Kuplyakov
> On Sept. 29, 2013, 4:24 p.m., David Faure wrote: > > The name "token" surprises me a bit. Is this a usual naming scheme for > > accessing C++ classes from QML? > > Otherwise I would think the QML code would want to just write KColorScheme. > > > > Maybe the registration could be done in a sta

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-06 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Oct. 6, 2013, 7:24 p.m.) Review request for KDE Frameworks and kd

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-06 Thread Denis Kuplyakov
> On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote: > > kdeui/colors/kcolorschemetoken.h, line 70 > > > > > > using int here loses the type-safety. Why no use the corresponding > > enums? It would also make the

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-01 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review41068 --- I'm not a huge fan of using Q_INVOKABLE for something that actu

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-29 Thread Denis Kuplyakov
> On Sept. 29, 2013, 4:24 p.m., David Faure wrote: > > The name "token" surprises me a bit. Is this a usual naming scheme for > > accessing C++ classes from QML? > > Otherwise I would think the QML code would want to just write KColorScheme. > > > > Maybe the registration could be done in a sta

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-29 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 29, 2013, 4:27 p.m.) Review request for KDE Frameworks and

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review41002 --- The name "token" surprises me a bit. Is this a usual naming sch

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-24 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 24, 2013, 4:08 p.m.) Review request for KDE Frameworks and

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/#review40635 --- I'm not sure we can let that in for kdelibs 4.x / kdeui... Davi

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-23 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112880/ --- (Updated Sept. 23, 2013, 2:43 p.m.) Review request for KDE Frameworks and