Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

2013-08-27 Thread David Faure
On Monday 26 August 2013 13:48:16 Albert Astals Cid wrote: >QStandardPaths::standardLocations(QStandardPaths::GenericDataLocation) + > QString::fromLatin1("locale/"); <-- note this does not compile :D QStandardPaths::locate(QStandardPaths::GenericDataLocation, "locale", QStandardPaths::Locate

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

2013-08-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112288/ --- (Updated Aug. 27, 2013, 8:41 a.m.) Status -- This change has been mar

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

2013-08-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112288/#review38715 --- This review has been submitted with commit bd132d22511ad4ae3f5

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

2013-08-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112288/#review38652 --- Ship it! staging/xmlgui/src/kswitchlanguagedialog_p.cpp

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

2013-08-26 Thread Kevin Ottens
> On Aug. 26, 2013, 1:35 p.m., Kevin Ottens wrote: > > staging/xmlgui/src/kswitchlanguagedialog_p.cpp, line 333 > > > > > > From QLocale documentation if the ctor didn't find the language in the > > database it t

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

2013-08-26 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112288/ --- (Updated Aug. 26, 2013, 2:34 p.m.) Review request for KDE Frameworks and A

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

2013-08-26 Thread Vishesh Handa
> On Aug. 26, 2013, 1:35 p.m., Kevin Ottens wrote: > > staging/xmlgui/src/kswitchlanguagedialog_p.cpp, line 333 > > > > > > From QLocale documentation if the ctor didn't find the language in the > > database it t

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

2013-08-26 Thread Albert Astals Cid
> On Aug. 26, 2013, 1:35 p.m., Kevin Ottens wrote: > > staging/xmlgui/src/kswitchlanguagedialog_p.cpp, line 333 > > > > > > From QLocale documentation if the ctor didn't find the language in the > > database it t

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

2013-08-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112288/#review38639 --- staging/xmlgui/src/kswitchlanguagedialog_p.cpp

Review Request 112288: fillApplicationLanguages: Do not add the system locale

2013-08-26 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112288/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Description

Re: Review Request 112288: fillApplicationLanguages: Do not add the system locale

2013-08-26 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112288/ --- (Updated Aug. 26, 2013, 1:06 p.m.) Review request for KDE Frameworks and A