Re: Review Request 111191: Move KTextEdit to KTextWidgets

2013-07-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/91/ --- (Updated July 3, 2013, 7:15 a.m.) Status -- This change has been mark

Re: Review Request 111191: Move KTextEdit to KTextWidgets

2013-07-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/91/#review35486 --- This review has been submitted with commit 6cf2e978ad82dfe1397

Re: Review Request 111191: Move KTextEdit to KTextWidgets

2013-07-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/91/#review35473 --- Ship it! There are a lot of QLatin1String("...") which should

Re: Review Request 111191: Move KTextEdit to KTextWidgets

2013-07-02 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/91/ --- (Updated July 2, 2013, 7 p.m.) Review request for KDE Frameworks. Change

Re: Review Request 111191: Move KTextEdit to KTextWidgets

2013-07-02 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/91/ --- (Updated July 2, 2013, 6:14 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 111191: Move KTextEdit to KTextWidgets

2013-07-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/91/#review35453 --- I guess I need a --find-copies-harder version of this to be abl

Re: Review Request 111191: Move KTextEdit to KTextWidgets

2013-07-02 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/91/ --- (Updated July 2, 2013, 3:32 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 111191: Move KTextEdit to KTextWidgets

2013-06-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/91/#review34984 --- staging/ktextwidgets/src/findreplace/kfinddialog.cpp

Re: Review Request 111191: Move KTextEdit to KTextWidgets

2013-06-24 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/91/ --- (Updated June 24, 2013, 10:45 a.m.) Review request for KDE Frameworks. C

Re: Review Request 111191: Move KTextEdit to KTextWidgets

2013-06-23 Thread David Faure
> On June 23, 2013, 5:17 p.m., Andrea Scarpino wrote: > > I didn't get this before. > > KGlobalSettings is used by KMessageWidget, so it looks as a candidate to > > KWidgetsAddons to me. This way all dependencies are solved as KTextWidgets > > already uses KWidgetsAddons. The plan is rather to

Re: Review Request 111191: Move KTextEdit to KTextWidgets

2013-06-23 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/91/#review34917 --- I didn't get this before. KGlobalSettings is used by KMessageWi

Review Request 111191: Move KTextEdit to KTextWidgets

2013-06-23 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/91/ --- Review request for KDE Frameworks. Description --- Move KFind, KFindD