Re: Review Request: Make kcodecs framework build standalone

2012-08-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105860/#review17148 --- This review has been submitted with commit f6c3868f9a2c5f8a96f

Re: Review Request: Make kcodecs framework build standalone

2012-08-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105860/#review17136 --- Ship it! Ship It! - David Faure On Aug. 8, 2012, 7:20 p.m.,

Re: Review Request: Make kcodecs framework build standalone

2012-08-09 Thread George Goldberg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105860/ --- (Updated Aug. 8, 2012, 7:20 p.m.) Review request for KDE Frameworks and Da

Re: Review Request: Make kcodecs framework build standalone

2012-08-09 Thread George Goldberg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105860/ --- (Updated Aug. 8, 2012, 2:07 p.m.) Review request for KDE Frameworks and Da

Re: Review Request: Make kcodecs framework build standalone

2012-08-08 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105860/#review17131 --- +1 (in qt-project terms) - Oswald Buddenhagen On Aug. 8, 201

Re: Review Request: Make kcodecs framework build standalone

2012-08-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105860/#review17112 --- Good work, just one issue. tier1/kcodecs/src/kcharsets.cpp

Re: Review Request: Make kcodecs framework build standalone

2012-08-07 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105860/#review17017 --- tier1/kcodecs/src/kcharsets.cpp

Re: Review Request: Make kcodecs framework build standalone

2012-08-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105860/#review16961 --- QObject::tr() sets a context of "QObject", which won't match. Y

Re: Review Request: Make kcodecs framework build standalone

2012-08-05 Thread George Goldberg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105860/ --- (Updated Aug. 5, 2012, 2:24 p.m.) Review request for KDE Frameworks and Da

Re: Review Request: Make kcodecs framework build standalone

2012-08-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105860/ --- (Updated Aug. 5, 2012, 9:22 a.m.) Review request for KDE Frameworks and Da