Re: marble builds when it shouldn't

2015-09-23 Thread Harald Sitter
On Wed, Sep 23, 2015 at 11:13 AM, Ben Cooksley wrote: > On Wed, Sep 23, 2015 at 7:25 AM, Scarlett Clark > wrote: >> That is correct. I have turned this off and on so many times it is not >> funny. Somehow everyone needs to agree on this. > > The issue primarily boils down to build log size, espec

Re: marble builds when it shouldn't

2015-09-23 Thread Ben Cooksley
On Wed, Sep 23, 2015 at 7:25 AM, Scarlett Clark wrote: > That is correct. I have turned this off and on so many times it is not > funny. Somehow everyone needs to agree on this. The issue primarily boils down to build log size, especially for the larger projects which take a long time to build -

Re: marble builds when it shouldn't

2015-09-22 Thread Scarlett Clark
That is correct. I have turned this off and on so many times it is not funny. Somehow everyone needs to agree on this. Scarlett On Tue, Sep 22, 2015 at 12:24 PM, Jan Kundrát wrote: > On Tuesday, 22 September 2015 13:00:38 CEST, Harald Sitter wrote: > >> Also on a more general note: I think it w

Re: marble builds when it shouldn't

2015-09-22 Thread Jan Kundrát
On Tuesday, 22 September 2015 13:00:38 CEST, Harald Sitter wrote: Also on a more general note: I think it would be handy if all builds used CMAKE_VERBOSE_MAKEFILE=TRUE to get verbose make output which would make it easier to notice when things such as -DNDEBUG are passed to gcc. Absolutely -- t

Re: marble builds when it shouldn't

2015-09-22 Thread Scarlett Clark
Looks like -DCMAKE_BUILD_TYPE=Release was set in Marble. I have removed it so your build should fail as expected. Scarlett On Tue, Sep 22, 2015 at 1:00 PM, Harald Sitter wrote: > ahoy ahoy, > > I have a bit of an unexpected CI outcome on build.kde.org. > > > https://build.kde.org/job/marble%20A