Re: kde4_add_plugin on KF5

2013-09-29 Thread Stephen Kelly
David Faure wrote: > On Thursday 19 September 2013 19:39:54 Alexander Neundorf wrote: >> But I think Stephens plan is to get rid of those macros and use plain >> cmake instead, i.e. add_library(... MODULE ...), as with add_executable() >> and add_library(). > > I've always been surprised that cma

Re: kde4_add_plugin on KF5

2013-09-28 Thread David Faure
On Thursday 19 September 2013 19:39:54 Alexander Neundorf wrote: > But I think Stephens plan is to get rid of those macros and use plain cmake > instead, i.e. add_library(... MODULE ...), as with add_executable() and > add_library(). I've always been surprised that cmake doesn't remove the "lib"

Re: kde4_add_plugin on KF5

2013-09-20 Thread Sebastian Kügler
On Friday, September 20, 2013 01:38:19 Aleix Pol wrote: > Ah, right. So maybe I can just change those to add_library(MODULE) and > forget about macros, right? Then you end up with a lib prefix for plugins, which should be removed. (Otherwise, we'll probably need to change plugin naming logic else

Re: kde4_add_plugin on KF5

2013-09-19 Thread Aleix Pol
On Thu, Sep 19, 2013 at 7:39 PM, Alexander Neundorf wrote: > On Thursday 19 September 2013, Alex Merry wrote: > > On 19/09/13 17:00, Aleix Pol wrote: > > > Hi, > > > We should decide what we do with the add_plugin macro. Should I install > > > it as kf5_add_plugin from KCoreAddons? Do we want some

Re: kde4_add_plugin on KF5

2013-09-19 Thread Alexander Neundorf
On Thursday 19 September 2013, Alex Merry wrote: > On 19/09/13 17:00, Aleix Pol wrote: > > Hi, > > We should decide what we do with the add_plugin macro. Should I install > > it as kf5_add_plugin from KCoreAddons? Do we want something different or > > better? > > Would e-c-m be the right place for

Re: kde4_add_plugin on KF5

2013-09-19 Thread Sebastian Kügler
On Thursday, September 19, 2013 18:26:54 Aleix Pol wrote: > Well, I thought of something like that, but I checked and there are projects > using the different arguments that kde4_add_plugin has. I don't see the > point of oversimplifying there. I didn't mean oversimplifying, but: - to provide ins

Re: kde4_add_plugin on KF5

2013-09-19 Thread Sebastian Kügler
On Thursday, September 19, 2013 18:00:41 Aleix Pol wrote: > Hi, > We should decide what we do with the add_plugin macro. Should I install it > as kf5_add_plugin from KCoreAddons? Do we want something different or > better? This is what we're using in Plasma (PlasmaMacros.cmake): # plasma_add_plug

Re: kde4_add_plugin on KF5

2013-09-19 Thread Alex Merry
On 19/09/13 17:00, Aleix Pol wrote: > Hi, > We should decide what we do with the add_plugin macro. Should I install > it as kf5_add_plugin from KCoreAddons? Do we want something different or > better? Would e-c-m be the right place for it? Alex ___ Kde

Re: kde4_add_plugin on KF5

2013-09-19 Thread Aleix Pol
On Thu, Sep 19, 2013 at 6:15 PM, Sebastian Kügler wrote: > On Thursday, September 19, 2013 18:00:41 Aleix Pol wrote: > > Hi, > > We should decide what we do with the add_plugin macro. Should I install > it > > as kf5_add_plugin from KCoreAddons? Do we want something different or > > better? > > T