Re: Review request: QBluez

2015-02-17 Thread David Rosca
> Well, then the test should try to detect it and QEXPECT_FAIL, havign tests > fail means something is bad, and as you say it's not bad, just expected. I meant it's expected to fail in the case that something goes wrong when initializing Manager. And that is, for example, the case with running Blu

Re: Review request: QBluez

2015-02-17 Thread Albert Astals Cid
El Dimarts, 17 de febrer de 2015, a les 22:39:16, David Rosca va escriure: > > That would work i guess, note it's not only about the project name, but > > also about the class names. > > Sure. > > > But i get two others to fail > > Any idea? > > Hmm, I would say that it is actually expected to f

Re: Review request: QBluez

2015-02-17 Thread David Rosca
> That would work i guess, note it's not only about the project name, but also > about the class names. Sure. > But i get two others to fail > Any idea? Hmm, I would say that it is actually expected to fail if there is an error when calling GetManagedObjects on org.freedesktop.DBus.ObjectManager

Re: Review request: QBluez

2015-02-17 Thread Albert Astals Cid
El Dimarts, 17 de febrer de 2015, a les 10:36:59, David Rosca va escriure: > > Using Q* is usually frowned upon since the Qt people have made it quick > > clear that they reserve the right to use Q* names themselves, i'd look > > for a new name. > > I see. What about renaming it to BluezQt? That

Re: Review request: QBluez

2015-02-17 Thread David Rosca
> Using Q* is usually frowned upon since the Qt people have made it quick clear > that they reserve the right to use Q* names themselves, i'd look for a new > name. I see. What about renaming it to BluezQt? > Also tried to run the tests and qbluez-managertest seems to get stuck forever. > Does it

Re: Review request: QBluez

2015-02-16 Thread Albert Astals Cid
El Dilluns, 16 de febrer de 2015, a les 10:40:44, David Rosca va escriure: > Hi all, > I'd like to ask for a review of the QBluez library [1]. Using Q* is usually frowned upon since the Qt people have made it quick clear that they reserve the right to use Q* names themselves, i'd look for a new