Re: Review Request 128672: some fixes for javascript Math object

2017-04-27 Thread Aleix Pol Gonzalez
> On des. 21, 2016, 10:24 p.m., Albert Astals Cid wrote: > > src/kjs/math_object.cpp, line 112 > > > > > > Why this change? > > Viktor Mv wrote: > `1.0 / log(10.0)` gives `0.43429448190325176`, not `0.434294

Re: Review Request 128672: some fixes for javascript Math object

2017-04-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128672/#review103139 --- This code clearly misses some tests. I'm also concerned that

Re: Review Request 128672: some fixes for javascript Math object

2017-04-27 Thread Viktor Mv
> On Dec. 21, 2016, 9:24 p.m., Albert Astals Cid wrote: > > src/kjs/math_object.cpp, line 112 > > > > > > Why this change? `1.0 / log(10.0)` gives `0.43429448190325176`, not `0.4342944819032518` - Viktor ---

Re: Review Request 128672: some fixes for javascript Math object

2016-12-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128672/#review101544 --- > The implementations were tested although. Could you share

Re: Review Request 128672: some fixes for javascript Math object

2016-12-18 Thread Viktor Mv
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128672/ --- (Updated Dec. 19, 2016, 3:32 a.m.) Review request for KDE Frameworks, Ber