Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Oct. 30, 2015, 7:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > > > > > That doesn't look very English to me ;) > > > > The original is: > > > > ExtraNames=Original

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Jan. 1, 2016, 6:12 p.m., Alex Richardson wrote: > > I added support for translating the ExtraNames key here: > > https://svn.reviewboard.kde.org/r/7154/ Cool ;=) Which nice new year present! Thanks! - Christoph --- This is an auto

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125869/#review90411 --- I added support for translating the ExtraNames key here: http

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Dec. 28, 2015, 5:20 p.m., Alex Richardson wrote: > > Could you post a patch with the JSON files? I'll look into implementing the > > translations then. Hi, atm my local build is broken, so no new patch, but I have attached the converted trash.protocol result. - Christoph -

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125869/ --- (Updated Dec. 28, 2015, 7:25 p.m.) Review request for KDE Frameworks, Alb

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125869/#review90237 --- Could you post a patch with the JSON files? I'll look into imp

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125869/ --- (Updated Dec. 27, 2015, 5:14 p.m.) Review request for KDE Frameworks, Alb

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Nov. 3, 2015, 9:47 p.m., Albert Astals Cid wrote: > > How does this work without modifying > > KProtocolInfoPrivate::KProtocolInfoPrivate? > > Christoph Cullmann wrote: > You mean the JSON stuff? That was implemented in > https://git.reviewboard.kde.org/r/125830/ > For the http sl

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Nov. 3, 2015, 9:47 p.m., Albert Astals Cid wrote: > > How does this work without modifying > > KProtocolInfoPrivate::KProtocolInfoPrivate? > > Christoph Cullmann wrote: > You mean the JSON stuff? That was implemented in > https://git.reviewboard.kde.org/r/125830/ > For the http sl

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On nov. 3, 2015, 9:47 p.m., Albert Astals Cid wrote: > > How does this work without modifying > > KProtocolInfoPrivate::KProtocolInfoPrivate? > > Christoph Cullmann wrote: > You mean the JSON stuff? That was implemented in > https://git.reviewboard.kde.org/r/125830/ > For the http sl

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Nov. 3, 2015, 9:47 p.m., Albert Astals Cid wrote: > > How does this work without modifying > > KProtocolInfoPrivate::KProtocolInfoPrivate? > > Christoph Cullmann wrote: > You mean the JSON stuff? That was implemented in > https://git.reviewboard.kde.org/r/125830/ > For the http sl

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Nov. 3, 2015, 9:47 p.m., Albert Astals Cid wrote: > > How does this work without modifying > > KProtocolInfoPrivate::KProtocolInfoPrivate? > > Christoph Cullmann wrote: > You mean the JSON stuff? That was implemented in > https://git.reviewboard.kde.org/r/125830/ > For the http sl

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On nov. 3, 2015, 9:47 p.m., Albert Astals Cid wrote: > > How does this work without modifying > > KProtocolInfoPrivate::KProtocolInfoPrivate? > > Christoph Cullmann wrote: > You mean the JSON stuff? That was implemented in > https://git.reviewboard.kde.org/r/125830/ > For the http sl

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Nov. 3, 2015, 9:47 p.m., Albert Astals Cid wrote: > > How does this work without modifying > > KProtocolInfoPrivate::KProtocolInfoPrivate? You mean the JSON stuff? That was implemented in https://git.reviewboard.kde.org/r/125830/ For the http slave, that already works nicely, but we misse

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125869/#review87966 --- How does this work without modifying KProtocolInfoPrivate::KPr

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Oct. 30, 2015, 8:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > > > > > That doesn't look very English to me ;) > > > > The original is: > > > > ExtraNames=Original

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Oct. 30, 2015, 7:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > > > > > That doesn't look very English to me ;) > > > > The original is: > > > > ExtraNames=Original

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Oct. 30, 2015, 7:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > > > > > That doesn't look very English to me ;) > > > > The original is: > > > > ExtraNames=Original

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Oct. 30, 2015, 7:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > > > > > That doesn't look very English to me ;) > > > > The original is: > > > > ExtraNames=Original

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Oct. 30, 2015, 7:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > > > > > That doesn't look very English to me ;) > > > > The original is: > > > > ExtraNames=Original

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Oct. 30, 2015, 7:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > > > > > That doesn't look very English to me ;) > > > > The original is: > > > > ExtraNames=Original

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Oct. 30, 2015, 7:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > > > > > That doesn't look very English to me ;) > > > > The original is: > > > > ExtraNames=Original

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Oct. 30, 2015, 7:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > > > > > That doesn't look very English to me ;) > > > > The original is: > > > > ExtraNames=Original

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125869/#review87721 --- src/ioslaves/file/file.cpp (line 80)

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125869/ --- (Updated Oct. 29, 2015, 5:03 p.m.) Review request for KDE Frameworks, Ale