Re: Review Request 125641: Allow PAM unlocking of a running wallet

2017-02-25 Thread Martin Klapetek
> On Feb. 25, 2017, 11:55 p.m., Albert Astals Cid wrote: > > Martin, Valentin, should I commit this? I honestly don't know what the state of this and/or the component(s) that needed it is. It was mainly meant for Plasma Mobile, no idea about that project either. I guess it should still work,

Re: Review Request 125641: Allow PAM unlocking of a running wallet

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125641/#review102608 --- Martin, Valentin, should I commit this? - Albert Astals Cid

Re: Review Request 125641: Allow PAM unlocking of a running wallet

2015-12-13 Thread Valentin Rusu
> On Oct. 23, 2015, 7:07 p.m., Boudhayan Gupta wrote: > > src/runtime/kwalletd/main.cpp, line 173 > > > > > > Is this necessary? Shouldn't KWallet::Wallet::isOpen() fail nicely if > > the wallet isn't running?

Re: Review Request 125641: Allow PAM unlocking of a running wallet

2015-11-06 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125641/#review88114 --- Ship it! Ship It! - Valentin Rusu On Oct. 16, 2015, 4:52 p

Re: Review Request 125641: Allow PAM unlocking of a running wallet

2015-10-23 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125641/#review87317 --- src/runtime/kwalletd/main.cpp (line 173)

Re: Review Request 125641: Allow PAM unlocking of a running wallet

2015-10-23 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125641/#review87316 --- "I originally didn't want to pass it over dbus, but in the end