Re: Review Request 124879: Optimization readEntryGui

2015-08-22 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124879/ --- (Updated Aug. 22, 2015, 5:11 p.m.) Status -- This change has been ma

Re: Review Request 124879: Optimization readEntryGui

2015-08-22 Thread Kevin Funk
> On Aug. 22, 2015, 5:05 p.m., Albert Astals Cid wrote: > > While you're at it move formatError down to the only place it is used? Done - Kevin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.

Re: Review Request 124879: Optimization readEntryGui

2015-08-22 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124879/#review84189 --- While you're at it move formatError down to the only place it

Re: Review Request 124879: Optimization readEntryGui

2015-08-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124879/#review84188 --- Ship it! nice use for a lambda :) - David Faure On Aug. 22

Re: Review Request 124879: Optimization readEntryGui

2015-08-22 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124879/#review84187 --- Looks good to me. - Volker Krause On Aug. 22, 2015, 3:06 p.