Re: Review Request 121747: Fix broken unittest for QFileDialog::setViewMode.

2014-12-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121747/ --- (Updated Dec. 31, 2014, 8:52 a.m.) Status -- This change has been ma

Re: Review Request 121747: Fix broken unittest for QFileDialog::setViewMode.

2014-12-31 Thread David Faure
> On Dec. 30, 2014, 12:11 a.m., Mark Gaiser wrote: > > autotests/kfiledialog_unittest.cpp, line 145 > > > > > > One more sace. where? (anyway I ran astyle-kdelibs now, so coding style should be good) On Dec. 3

Re: Review Request 121747: Fix broken unittest for QFileDialog::setViewMode.

2014-12-31 Thread David Faure
> On Dec. 30, 2014, 12:05 a.m., Aleix Pol Gonzalez wrote: > > autotests/kfiledialog_unittest.cpp, line 150 > > > > > > switch()? Use QStringLiteral? Done. This was taken from kfile.cpp, which has if()s. > On D

Re: Review Request 121747: Fix broken unittest for QFileDialog::setViewMode.

2014-12-29 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121747/#review72757 --- Ship it! autotests/kfiledialog_unittest.cpp

Re: Review Request 121747: Fix broken unittest for QFileDialog::setViewMode.

2014-12-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121747/#review72758 --- +1 I like it. Some late-night nitpicking. Feel free to ignore