Re: Review Request 121400: Add a new macro to create VERSIONINFO resources for Windows

2014-12-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121400/#review71865 --- This needs a unit test comparing generated output with what yo

Re: Review Request 121400: Add a new macro to create VERSIONINFO resources for Windows

2014-12-10 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121400/ --- (Updated Dec. 10, 2014, 8:57 p.m.) Review request for Build System and KD

Re: Review Request 121400: Add a new macro to create VERSIONINFO resources for Windows

2014-12-10 Thread Alex Merry
> On Dec. 10, 2014, 8:38 p.m., Alex Merry wrote: > > What happens if you miss out an argument (ie: you put an empty string in > > the file)? Is that the same as not including the corresponding VALUE line > > in the file at all? > > > > Also, it would be nice to be able to optionally pass the v

Re: Review Request 121400: Add a new macro to create VERSIONINFO resources for Windows

2014-12-10 Thread Nicolás Alvarez
> On Dec. 10, 2014, 5:38 p.m., Alex Merry wrote: > > What happens if you miss out an argument (ie: you put an empty string in > > the file)? Is that the same as not including the corresponding VALUE line > > in the file at all? > > > > Also, it would be nice to be able to optionally pass the v

Re: Review Request 121400: Add a new macro to create VERSIONINFO resources for Windows

2014-12-10 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121400/#review71745 --- What happens if you miss out an argument (ie: you put an empty