Re: Review Request 120408: Port textcreator thumbnailer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120408/ --- (Updated Sept. 29, 2014, 7:42 p.m.) Status -- This change has been m

Re: Review Request 120408: Port textcreator thumbnailer

> On Sept. 28, 2014, 10:47 p.m., Christoph Feck wrote: > > Ship It! Please CC bug 339456. - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120408/#review67599

Re: Review Request 120408: Port textcreator thumbnailer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120408/#review67599 --- Ship it! Ship It! - Christoph Feck On Sept. 28, 2014, 10:4

Re: Review Request 120408: Port textcreator thumbnailer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120408/ --- (Updated Sept. 28, 2014, 10:41 p.m.) Review request for KDE Frameworks.

Re: Review Request 120408: Port textcreator thumbnailer

> On Sept. 28, 2014, 8:58 p.m., Christoph Feck wrote: > > thumbnail/CMakeLists.txt, line 110 > > > > > > Could you make this line match the previous version (one space after > > first #) for consistency with the

Re: Review Request 120408: Port textcreator thumbnailer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120408/#review67589 --- thumbnail/CMakeLists.txt

Re: Review Request 120408: Port textcreator thumbnailer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120408/#review67586 --- I suggest to keep the KEncodingProber code for now, as the cha

Re: Review Request 120408: Port textcreator thumbnailer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120408/#review67584 --- ah, the QGuiApplication does the trick :D i had almost identic