Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/ --- (Updated March 31, 2014, 4:23 p.m.) Status -- This change has been m

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/#review54704 --- This review has been submitted with commit 953f6afab51bc2249b

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-31 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/#review54701 --- Ship it! Ship It! - Kevin Ottens On March 31, 2014, 3:34 p

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/ --- (Updated March 31, 2014, 3:34 p.m.) Review request for KDE Frameworks, Da

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-31 Thread Alex Merry
> On March 31, 2014, 2:49 p.m., Kevin Ottens wrote: > > src/plugin/kpluginloader.h, line 305 > > > > > > Why is this class all inlined? Because it's a pretty trivial container class. It was patterned off things

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-31 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/#review54686 --- Couple of nitpicks, overall I like where this is going. src/

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-30 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/ --- (Updated March 30, 2014, 11:41 a.m.) Review request for KDE Frameworks, D

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/#review54587 --- Hmm. It looks like a bit of a kludge, but it works. No objecti

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-30 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/ --- (Updated March 30, 2014, 11:28 a.m.) Review request for KDE Frameworks an