Re: Review Request 116568: Fixes to PIC image format handler

2014-04-01 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116568/ --- (Updated April 1, 2014, 1:27 p.m.) Status -- This change has been di

Re: Review Request 116568: Fixes to PIC image format handler

2014-03-06 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116568/#review52275 --- A few methods have mismatched params in their header comments.

Re: Review Request 116568: Fixes to PIC image format handler

2014-03-04 Thread Alex Merry
> On March 4, 2014, 8:28 a.m., David Faure wrote: > > src/imageformats/pic.cpp, line 452 > > > > > > Does this work on both big endian and little endian architectures? It > > looks like it's extracting individua

Re: Review Request 116568: Fixes to PIC image format handler

2014-03-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116568/#review51854 --- Ship it! Too many C casts to not get nightmares, but other th

Re: Review Request 116568: Fixes to PIC image format handler

2014-03-03 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116568/ --- (Updated March 3, 2014, 1:15 p.m.) Review request for KDE Frameworks and