Re: Review Request 115343: Fix msvc build of solid

2014-02-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115343/#review48932 --- This review has been submitted with commit 85d9cc0c44a907a118

Re: Review Request 115343: Fix msvc build of solid

2014-02-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115343/#review48933 --- This review has been submitted with commit 956bc192240b83f685

Re: Review Request 115343: Fix msvc build of solid

2014-02-04 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115343/ --- (Updated Feb. 4, 2014, 3:43 p.m.) Status -- This change has been mar

Re: Review Request 115343: Fix msvc build of solid

2014-02-04 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115343/#review48897 --- Ship it! Ship It! - Alex Merry On Feb. 4, 2014, 12:04 a.m.

Re: Review Request 115343: Fix msvc build of solid

2014-02-03 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115343/ --- (Updated Feb. 4, 2014, 1:04 a.m.) Review request for KDE Frameworks. Re

Re: Review Request 115343: Fix msvc build of solid

2014-02-03 Thread Alex Merry
> On Jan. 31, 2014, 7:41 p.m., Alex Merry wrote: > > src/solid/networking_win.cpp, lines 116-117 > > > > > > It's odd that this should be needed. Do you have any way of getting > > verbose output? > > (http:/

Re: Review Request 115343: Fix msvc build of solid

2014-02-03 Thread Alexander Richardson
> On Jan. 31, 2014, 8:41 p.m., Alex Merry wrote: > > src/solid/networking_win.cpp, lines 116-117 > > > > > > It's odd that this should be needed. Do you have any way of getting > > verbose output? > > (http:/

Re: Review Request 115343: Fix msvc build of solid

2014-01-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115343/#review48706 --- src/solid/networking_win.cpp