Re: Review Request 115063: Created missing manpage for desktoptojson binary

2014-01-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115063/#review47823 --- This review has been submitted with commit f03dd455e68f64fdd9

Re: Review Request 115063: Created missing manpage for desktoptojson binary

2014-01-20 Thread Scarlett Clark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115063/ --- (Updated Jan. 20, 2014, 4:59 p.m.) Status -- This change has been ma

Re: Review Request 115063: Created missing manpage for desktoptojson binary

2014-01-20 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115063/#review47818 --- Ship it! No need for another diff thanks docs/desktoptojson

Re: Review Request 115063: Created missing manpage for desktoptojson binary

2014-01-17 Thread Scarlett Clark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115063/ --- (Updated Jan. 17, 2014, 8:10 a.m.) Review request for Documentation, KDE

Re: Review Request 115063: Created missing manpage for desktoptojson binary

2014-01-17 Thread Burkhard Lück
> On Jan. 17, 2014, 10:46 a.m., Sebastian Kügler wrote: > > Hi Scarlett, > > > > Congrats to your first patch (that I see coming by)! I think it's a useful > > contribution and as far as I can judge, almost good to go in. I've put a > > comment inline how the explanation could be further impro

Re: Review Request 115063: Created missing manpage for desktoptojson binary

2014-01-17 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115063/#review47561 --- Hi Scarlett, Congrats to your first patch (that I see coming