Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-12 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114336/ --- (Updated Dec. 12, 2013, 1:33 p.m.) Status -- This change has been mar

Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114336/#review45603 --- This review has been submitted with commit 4fa4990da4640c3d395

Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-10 Thread Aurélien Gâteau
Le mardi 10 décembre 2013 11:07:17 Stephen Kelly a écrit : > Aurélien Gâteau wrote: > >> when CMake 3.0.0 is depended on. > > > > Sounds good, we will be able to simplify the macro at this point then. > > The two threads on this is causing confusion. Agreed, let's continue in the newer thread.

Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-10 Thread Stephen Kelly
Aurélien Gâteau wrote: >> when CMake 3.0.0 is depended on. > > Sounds good, we will be able to simplify the macro at this point then. The two threads on this is causing confusion. Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-

Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-10 Thread Aurélien Gâteau
Le mardi 10 décembre 2013 10:02:18 Stephen Kelly a écrit : > Aurélien Gâteau wrote: > > Le lundi 9 décembre 2013 21:56:52 Stephen Kelly a écrit : > >> Aurélien Gâteau wrote: > >> > target_include_directories(${library} INTERFACE > >> > "$ >> > ${CMAKE_INSTALL_PREFIX}/${${library}_INCLUDE_INSTALL_DI

Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-10 Thread Stephen Kelly
Aurélien Gâteau wrote: > Le lundi 9 décembre 2013 21:56:52 Stephen Kelly a écrit : >> Aurélien Gâteau wrote: >> > target_include_directories(${library} INTERFACE >> > "$> > ${CMAKE_INSTALL_PREFIX}/${${library}_INCLUDE_INSTALL_DIR}>" >> > ) >> >> Note that this makes the resulting package non-relo

Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-10 Thread Aurélien Gâteau
Le lundi 9 décembre 2013 21:56:52 Stephen Kelly a écrit : > Aurélien Gâteau wrote: > > target_include_directories(${library} INTERFACE > > "$ > ${CMAKE_INSTALL_PREFIX}/${${library}_INCLUDE_INSTALL_DIR}>" > > ) > > Note that this makes the resulting package non-relocatable. If using CMake > 3.0.0,

Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-09 Thread Stephen Kelly
Aurélien Gâteau wrote: > target_include_directories(${library} INTERFACE > "$ ${CMAKE_INSTALL_PREFIX}/${${library}_INCLUDE_INSTALL_DIR}>" > ) Note that this makes the resulting package non-relocatable. If using CMake 3.0.0, you can specify a relative path here. With 2.8.12, you should use $ ins

Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-09 Thread Aurélien Gâteau
Le samedi 7 décembre 2013 14:51:33 Stephen Kelly a écrit : > Aurélien Gâteau wrote: > >> On Dec. 6, 2013, 5:15 p.m., Alexander Richardson wrote: > >> > Just wondering, should include/KF5 also be the include dir for > >> > applications that install headers e.g. for writing plugins? Since I > >> > gu

Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-07 Thread Stephen Kelly
Aurélien Gâteau wrote: > > >> On Dec. 6, 2013, 5:15 p.m., Alexander Richardson wrote: >> > Just wondering, should include/KF5 also be the include dir for >> > applications that install headers e.g. for writing plugins? Since I >> > guess they will also be using KDEInstallDirs.cmake > > Good que

Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-06 Thread Aurélien Gâteau
> On Dec. 6, 2013, 5:15 p.m., Alexander Richardson wrote: > > Just wondering, should include/KF5 also be the include dir for applications > > that install headers e.g. for writing plugins? Since I guess they will also > > be using KDEInstallDirs.cmake Good question. This was not discussed in t

Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-06 Thread Aurélien Gâteau
> On Dec. 6, 2013, 5:06 p.m., Michael Palimaka wrote: > > kde-modules/KDEInstallDirs.cmake, line 131 > > > > > > Is the capitalisation intentional? Most other stuff seems to be in > > lowercase. It was agreed to

Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-06 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114336/#review45278 --- Just wondering, should include/KF5 also be the include dir for

Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-06 Thread Johannes Huber
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114336/#review45275 --- How about to make it lowercase? - Johannes Huber On Dec. 6,

Re: Review Request 114336: Install all includes in a KF5 dir

2013-12-06 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114336/#review45274 --- kde-modules/KDEInstallDirs.cmake