Re: Review Request 112570: Port some kde4_add_executable usages to add_executable

2013-09-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112570/#review39871 --- This review has been submitted with commit c5ba76f443d62ada457

Re: Review Request 112570: Port some kde4_add_executable usages to add_executable

2013-09-10 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112570/#review39734 --- Ship it! Ship It! - Stephen Kelly On Sept. 10, 2013, 3:49 p

Re: Review Request 112570: Port some kde4_add_executable usages to add_executable

2013-09-10 Thread David Faure
> On Sept. 8, 2013, 9:24 a.m., David Faure wrote: > > kinit/CMakeLists.txt, line 44 > > > > > > This could also be moved out of the if, by using the proper arguments > > for ecm_mark_nongui_executable, so that it

Re: Review Request 112570: Port some kde4_add_executable usages to add_executable

2013-09-09 Thread Aleix Pol Gonzalez
> On Sept. 8, 2013, 9:24 a.m., David Faure wrote: > > kinit/CMakeLists.txt, line 44 > > > > > > This could also be moved out of the if, by using the proper arguments > > for ecm_mark_nongui_executable, so that it

Re: Review Request 112570: Port some kde4_add_executable usages to add_executable

2013-09-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112570/ --- (Updated Sept. 9, 2013, 4:49 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 112570: Port some kde4_add_executable usages to add_executable

2013-09-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112570/#review39569 --- Anything that had "TEST" should now have ecm_mark_as_test. You