Re: Review Request 112407: Port KJob to QEventLoopLocker

2013-09-05 Thread Aurélien Gâteau
> On Sept. 1, 2013, 10:11 a.m., David Faure wrote: > > Testing that it compiles isn't enough, please test that the unittests still > > pass. :) > > > > Too bad I can't find a test for this precise feature, but at least it would > > be good to check that nothing regresses. Just checked tests d

Re: Review Request 112407: Port KJob to QEventLoopLocker

2013-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112407/ --- (Updated Sept. 5, 2013, 9:30 a.m.) Status -- This change has been mar

Re: Review Request 112407: Port KJob to QEventLoopLocker

2013-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112407/#review39400 --- This review has been submitted with commit 72b83f857a6a0ec0477

Re: Review Request 112407: Port KJob to QEventLoopLocker

2013-09-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112407/#review39199 --- I have to pack for my holidays so can't do the change David sug

Re: Review Request 112407: Port KJob to QEventLoopLocker

2013-09-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112407/#review39047 --- Ship it! Testing that it compiles isn't enough, please test th

Re: Review Request 112407: Port KJob to QEventLoopLocker

2013-08-31 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112407/ --- (Updated Aug. 31, 2013, 4:29 p.m.) Review request for KDE Frameworks. De