Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111636/#review38242 --- This review has been submitted with commit cfb763585135746cb5f

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111636/ --- (Updated Aug. 20, 2013, 9:31 p.m.) Status -- This change has been mar

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

> On Aug. 20, 2013, 9:27 a.m., David Faure wrote: > > staging/kio/src/core/authinfo.cpp, line 545 > > > > > > let's hope macdef always comes *after* machine, otherwise index won't > > be set yet at this point...

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111636/#review38190 --- Ship it! Ok for pushing (just one last issue to fix first) s

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111636/ --- (Updated Aug. 19, 2013, 9:41 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111636/#review38098 --- staging/kio/src/core/authinfo.cpp

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111636/ --- (Updated Aug. 18, 2013, 10 p.m.) Review request for KDE Frameworks. Chan

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

> On July 23, 2013, 9:42 a.m., Kevin Ottens wrote: > > It would be nice if your test program could be turned into an automated > > test and added to this review. > > David Gil Oliva wrote: > Ok, I'll try. Finally, I used kionetrctest, which works fine. - David -

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

> On July 23, 2013, 11:19 a.m., David Faure wrote: > > staging/kio/src/core/authinfo.cpp, line 523 > > > > > > Making a member variable read from a function-local iodevice sounds > > dangerous to me. If you use d

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111636/#review37349 --- Hello David, any chance for a second revision of that patch? -

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

> On July 23, 2013, 11:19 a.m., David Faure wrote: > > staging/kio/src/core/authinfo.cpp, line 324 > > > > > > For some reason Qt has a Q_FOREVER() macro for this. I admit that I'm > > not sure what it difference

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

> On July 23, 2013, 9:42 a.m., Kevin Ottens wrote: > > staging/kio/src/core/authinfo.h, line 375 > > > > > > Should be "const QString &" > > David Gil Oliva wrote: > I think you didn't notice something import

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

> On July 23, 2013, 9:42 a.m., Kevin Ottens wrote: > > staging/kio/src/core/authinfo.h, line 375 > > > > > > Should be "const QString &" > > David Gil Oliva wrote: > I think you didn't notice something import

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

> On July 23, 2013, 9:42 a.m., Kevin Ottens wrote: > > staging/kio/src/core/authinfo.h, line 375 > > > > > > Should be "const QString &" > > David Gil Oliva wrote: > I think you didn't notice something import

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

> On July 23, 2013, 9:42 a.m., Kevin Ottens wrote: > > staging/kio/src/core/authinfo.h, line 375 > > > > > > Should be "const QString &" > > David Gil Oliva wrote: > I think you didn't notice something import

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

> On July 23, 2013, 11:19 a.m., David Faure wrote: > > staging/kio/src/core/authinfo.cpp, line 324 > > > > > > For some reason Qt has a Q_FOREVER() macro for this. I admit that I'm > > not sure what it difference

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

> On July 23, 2013, 9:42 a.m., Kevin Ottens wrote: > > It would be nice if your test program could be turned into an automated > > test and added to this review. Ok, I'll try. > On July 23, 2013, 9:42 a.m., Kevin Ottens wrote: > > staging/kio/src/core/authinfo.h, line 375 > >

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

> On July 23, 2013, 11:19 a.m., David Faure wrote: > > staging/kio/src/core/authinfo.cpp, line 324 > > > > > > For some reason Qt has a Q_FOREVER() macro for this. I admit that I'm > > not sure what it difference

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

> On July 23, 2013, 11:19 a.m., David Faure wrote: > > staging/kio/src/core/authinfo.cpp, line 324 > > > > > > For some reason Qt has a Q_FOREVER() macro for this. I admit that I'm > > not sure what it difference

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111636/#review36282 --- staging/kio/src/core/authinfo.cpp

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111636/#review36350 --- It would be nice if your test program could be turned into an a