Re: Review Request: Cleanup : Move all gesture facilities of KAction in KGestureMap

2013-01-04 Thread Valentin Rusu
> On Jan. 4, 2013, 7:56 a.m., Kevin Ottens wrote: > > kdeui/shortcuts/kgesturemap.h, line 44 > > > > > > I'd expect to see the action as first parameter since we're kind of > > moving from "action->setGesture(gest

Re: Review Request: Cleanup : Move all gesture facilities of KAction in KGestureMap

2013-01-04 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107973/ --- (Updated Jan. 4, 2013, 9:18 p.m.) Review request for KDE Frameworks and Ke

Re: Review Request: Cleanup : Move all gesture facilities of KAction in KGestureMap

2013-01-04 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107973/#review24635 --- OK, we're getting there. More fine-grained API proposals this t

Re: Review Request: Cleanup : Move all gesture facilities of KAction in KGestureMap

2012-12-30 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107973/ --- (Updated Dec. 30, 2012, 3:43 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request: Cleanup : Move all gesture facilities of KAction in KGestureMap

2012-12-30 Thread Valentin Rusu
> On Dec. 28, 2012, 5:17 p.m., Kevin Ottens wrote: > > kdeui/actions/kaction.h, line 460 > > > > > > Since the end game is to move KAction in kde4support, we should try to > > keep its API unchanged. > > > >

Re: Review Request: Cleanup : Move all gesture facilities of KAction in KGestureMap

2012-12-28 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107973/#review24126 --- I didn't scrutinize the details of the patch yet, I just commen

Re: Review Request: Cleanup : Move all gesture facilities of KAction in KGestureMap

2012-12-28 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107973/ --- (Updated Dec. 28, 2012, 11:32 a.m.) Review request for KDE Frameworks. D