Re: QString -> QStringLiteral conversions might make applications crash on exit

2016-02-29 Thread Jan Kundrát
On Monday, 29 February 2016 23:16:22 CET, Frank Reininghaus wrote: If something like "do not use QStringLiteral in plugins" will be the conclusion from this issue, then I'm all for continuing to use QStringLiteral everywhere else in order to avoid heap allocations. The conclusion is "do not unl

Re: QString -> QStringLiteral conversions might make applications crash on exit

2016-02-29 Thread Frank Reininghaus
Hi, 2016-02-29 19:04 GMT+01:00 Milian Wolff: > On Friday, February 26, 2016 1:37:57 AM CET Frank Reininghaus wrote: >> Hi everyone, >> >> sorry if most of you know about this already, but since it seems that >> QStringLiterals are being introduced everywhere right now, I think >> that it is import

Re: QString -> QStringLiteral conversions might make applications crash on exit

2016-02-29 Thread Milian Wolff
On Friday, February 26, 2016 1:37:57 AM CET Frank Reininghaus wrote: > Hi everyone, > > sorry if most of you know about this already, but since it seems that > QStringLiterals are being introduced everywhere right now, I think > that it is important to raise awareness about the fact that this migh

Re: QString -> QStringLiteral conversions might make applications crash on exit

2016-02-28 Thread Frank Reininghaus
Hi Albert, 2016-02-28 11:54 GMT+01:00 Albert Astals Cid: > El Friday 26 February 2016, a les 01:37:57, Frank Reininghaus va escriure: >> Hi everyone, >> >> sorry if most of you know about this already, but since it seems that >> QStringLiterals are being introduced everywhere right now, I think >>

Re: QString -> QStringLiteral conversions might make applications crash on exit

2016-02-28 Thread Frank Reininghaus
Hi, 2016-02-26 13:25 GMT+01:00 Jan Kundrát: > On Friday, 26 February 2016 01:37:57 CET, Frank Reininghaus wrote: >> >> This becomes a problem if the read-only data that the QString refers >> to are not there any more, which can happen if the QString was stored >> in a global static object from one

Re: QString -> QStringLiteral conversions might make applications crash on exit

2016-02-28 Thread Albert Astals Cid
El Friday 26 February 2016, a les 01:37:57, Frank Reininghaus va escriure: > Hi everyone, > > sorry if most of you know about this already, but since it seems that > QStringLiterals are being introduced everywhere right now, I think > that it is important to raise awareness about the fact that thi

Re: QString -> QStringLiteral conversions might make applications crash on exit

2016-02-26 Thread Jan Kundrát
On Friday, 26 February 2016 01:37:57 CET, Frank Reininghaus wrote: This becomes a problem if the read-only data that the QString refers to are not there any more, which can happen if the QString was stored in a global static object from one library, and the QStringLiteral is from another library,

Re: QString -> QStringLiteral conversions might make applications crash on exit

2016-02-26 Thread Nick Shaforostoff
> a) Everyone who makes QString -> QStringLiteral replacements should be > extremely careful (which is very difficult, since it is not always > obvious if passing a QString to a function will result in the string > being stored in a global static object). Automated tools like clazy > should then no