Re: Patch: port kError to qError and kFatal to qFatal

2013-01-10 Thread David Faure
On Thursday 10 January 2013 10:49:10 Jignesh Kakadiya wrote: > Here cmd is int so I haven't made any changes. for listit I used qWarning() > followed by abort(). Please review it. Ah. Well, if cmd is int, you have to use %d rather than %s. -- David Faure, fa...@kde.org, http://www.davidfaure.fr

Re: Patch: port kError to qError and kFatal to qFatal

2013-01-09 Thread Jignesh Kakadiya
Here cmd is int so I haven't made any changes. for listit I used qWarning() followed by abort(). Please review it. On Wed, Jan 9, 2013 at 5:16 PM, David Faure wrote: > On Wednesday 09 January 2013 16:45:08 Jignesh Kakadiya wrote: > > Hi David, > > > > I have ported all kError calls to qWarning

Re: Patch: port kError to qError and kFatal to qFatal

2013-01-09 Thread David Faure
On Wednesday 09 January 2013 16:45:08 Jignesh Kakadiya wrote: > Hi David, > > I have ported all kError calls to qWarning and kFatal to qFatal in > kdelibs/kio/kio directory. Compiles successfully. Please review it. > > Next patch will be removal of kdebug.h include from kio/kio. qFatal("Fatal Er