Re: Making KFileMetaData a framework

2014-08-12 Thread Kevin Ottens
On Wednesday 06 August 2014 17:47:49 Milian Wolff wrote: > > > Though note that the above does not mean that a call to extract would be > > > async. It would still be sync. But you could use QFile and its readyRead > > > signals internally to process stuff asynchronously and then emit the > > > dat

Re: Making KFileMetaData a framework

2014-08-12 Thread Kevin Ottens
On Wednesday 06 August 2014 16:09:19 Milian Wolff wrote: > On Wednesday 06 August 2014 16:05:27 Vishesh Handa wrote: > > On Tuesday, August 05, 2014 11:19:16 PM Kevin Ottens wrote: > > > Hello, > > > > > > On Tuesday 05 August 2014 18:36:24 Vishesh Handa wrote: > > > > I would appreciate it if eve

Re: Making KFileMetaData a framework

2014-08-06 Thread Milian Wolff
On Wednesday 06 August 2014 17:29:40 Vishesh Handa wrote: > On Wednesday, August 06, 2014 04:09:19 PM Milian Wolff wrote: > > > Hmm, how would we do async? I thought people could just run it in > > > another > > > thread / process if they want. The only thing I can think of changing is > > > that t

Re: Making KFileMetaData a framework

2014-08-06 Thread Vishesh Handa
On Wednesday, August 06, 2014 04:09:19 PM Milian Wolff wrote: > > > > Hmm, how would we do async? I thought people could just run it in another > > thread / process if they want. The only thing I can think of changing is > > that the plugins return the result later via a signal instead of doing al

Re: Making KFileMetaData a framework

2014-08-06 Thread Milian Wolff
On Wednesday 06 August 2014 16:05:27 Vishesh Handa wrote: > On Tuesday, August 05, 2014 11:19:16 PM Kevin Ottens wrote: > > Hello, > > > > On Tuesday 05 August 2014 18:36:24 Vishesh Handa wrote: > > > I would appreciate it if everyone could review the code once before it > > > gets > > > into fram

Re: Making KFileMetaData a framework

2014-08-06 Thread Vishesh Handa
On Tuesday, August 05, 2014 11:19:16 PM Kevin Ottens wrote: > Hello, > > On Tuesday 05 August 2014 18:36:24 Vishesh Handa wrote: > > I would appreciate it if everyone could review the code once before it > > gets > > into frameworks. > > metainfo.yaml should have "release: false" until it's part

Re: Making KFileMetaData a framework

2014-08-06 Thread Milian Wolff
On Tuesday 05 August 2014 19:58:03 David Edmundson wrote: > In general that's some of the tidied code I've seen in a long time. > > Comments below. One major, most not. > > > TypeInfo/PropertyInfo/SimpleExtractionResult need a working &operator= > otherwise we shallow copy d. > > I can caus

Re: Making KFileMetaData a framework

2014-08-06 Thread Vishesh Handa
On Tuesday, August 05, 2014 07:58:03 PM David Edmundson wrote: > In general that's some of the tidied code I've seen in a long time. Thanks! > > Comments below. One major, most not. > > > TypeInfo/PropertyInfo/SimpleExtractionResult need a working &operator= > otherwise we shallow copy d.

Re: Making KFileMetaData a framework

2014-08-05 Thread Kevin Ottens
Hello, On Tuesday 05 August 2014 18:36:24 Vishesh Handa wrote: > I would appreciate it if everyone could review the code once before it gets > into frameworks. metainfo.yaml should have "release: false" until it's part of a KF release. Also it should be integration and not functional (relies on

Re: Making KFileMetaData a framework

2014-08-05 Thread David Edmundson
In general that's some of the tidied code I've seen in a long time. Comments below. One major, most not. TypeInfo/PropertyInfo/SimpleExtractionResult need a working &operator= otherwise we shallow copy d. I can cause a crash in dump.cpp Extracting info from a file can take a long time