Re: KTabWidget vs QTabWidget

2015-10-04 Thread Jeremy Whiting
Thanks, First patch here: https://git.reviewboard.kde.org/r/125521/. After that I'll try using it in Kile and Okular, see how that goes. On Thu, Sep 24, 2015 at 11:47 PM, Michel Ludwig wrote: > > On 09/25/2015 01:57 AM, Jeremy Whiting wrote: >> >> Michel, >> >> Would you mind if I move the DropW

Re: KTabWidget vs QTabWidget

2015-09-25 Thread Michel Ludwig
On 09/25/2015 01:57 AM, Jeremy Whiting wrote: Michel, Would you mind if I move the DropWidget you wrote for kile into kwidgetsaddons and give it a name like KDropWidget and relicense it to LGPL v2+ ? That's totally fine with me. Michel ___ Kde-fram

Re: KTabWidget vs QTabWidget

2015-09-24 Thread Jeremy Whiting
Michel, Would you mind if I move the DropWidget you wrote for kile into kwidgetsaddons and give it a name like KDropWidget and relicense it to LGPL v2+ ? On Thu, Sep 24, 2015 at 2:09 AM, Andreas Cord-Landwehr wrote: > On Wednesday, September 23, 2015 4:12:01 PM CEST Jeremy Whiting wrote: > >> Ye

Re: KTabWidget vs QTabWidget

2015-09-24 Thread Andreas Cord-Landwehr
On Wednesday, September 23, 2015 4:12:01 PM CEST Jeremy Whiting wrote: > Yes, the two authors of that code are Michel Ludwig and Andreas > Cord-Landwehr who both are listed in relicensecheck.pl as giving > permission to change to lgpl+ So I think we should be fine to > move/copy that in and start u

Re: KTabWidget vs QTabWidget

2015-09-24 Thread David Faure
On Wednesday 23 September 2015 16:12:01 Jeremy Whiting wrote: > Yes, the two authors of that code are Michel Ludwig and Andreas > Cord-Landwehr who both are listed in relicensecheck.pl as giving > permission to change to lgpl+ So I think we should be fine to Small confusion there. In relicensechec

Re: KTabWidget vs QTabWidget

2015-09-23 Thread Jeremy Whiting
Yes, the two authors of that code are Michel Ludwig and Andreas Cord-Landwehr who both are listed in relicensecheck.pl as giving permission to change to lgpl+ So I think we should be fine to move/copy that in and start using it in stead of the copy in kile. On Tue, Sep 22, 2015 at 3:45 PM, Luigi T

Re: KTabWidget vs QTabWidget

2015-09-22 Thread Luigi Toscano
Jeremy Whiting ha scritto: > In looking at what is using KTabWidget it seems there's a drop in > replacement for what we are doing in > http://lxr.kde.org/source/extragear/office/kile/src/kileviewmanager.h > in DropWidget towards the bottom. Could/should we simply copy that to > kwidgetsaddons and

Re: KTabWidget vs QTabWidget

2015-09-22 Thread Jeremy Whiting
In looking at what is using KTabWidget it seems there's a drop in replacement for what we are doing in http://lxr.kde.org/source/extragear/office/kile/src/kileviewmanager.h in DropWidget towards the bottom. Could/should we simply copy that to kwidgetsaddons and rename it KDropWidgetDecorator and us

Re: KTabWidget vs QTabWidget

2015-09-22 Thread David Faure
On Monday 21 September 2015 20:16:01 Jeremy Whiting wrote: > David, > > I've been considering what you mean. I think I understand, but wanted > to check before I spend a bit of time trying to implement what you > described. Does the class below fit what you are considering? > > class KDropWidgetD

Re: KTabWidget vs QTabWidget

2015-09-21 Thread Jeremy Whiting
David, I've been considering what you mean. I think I understand, but wanted to check before I spend a bit of time trying to implement what you described. Does the class below fit what you are considering? class KDropWidgetDecorator: public QObject { Q_OBJECT public: void installEventFilter(QW

Re: KTabWidget vs QTabWidget

2015-09-19 Thread David Faure
On Friday 18 September 2015 18:46:24 Jeremy Whiting wrote: > Hey all, > > In looking into fixing the remaining issues in Okular's frameworks > branch I realized that in part of the effort to port it away from > KDELibs4Support it got some functionality removed. It was ported from > KTabWidget to Q