Re: KFilePlacesModelTest

2016-05-11 Thread David Faure
On Saturday 07 May 2016 19:50:36 Michael Pyne wrote: > On Sat, May 7, 2016 14:33:53 David Faure wrote: > > The thing I wonder is... does it really make sense to have a model with > > random ordering? Isn't it a problem for users if their visible list of > > places is different between every run? Or

Re: KFilePlacesModelTest

2016-05-08 Thread Giuseppe D'Angelo
Il 07/05/2016 20:05, David Faure ha scritto: We disable seed randomisation and sse4.2 (can't remember why that mattered, that was something Volker found out iirc), and that made it pass until recently, I'm not sure what changed. Isn't that inherently dangerous though? Even with those disabled,

Re: KFilePlacesModelTest

2016-05-08 Thread Giuseppe D'Angelo
Il 07/05/2016 14:33, David Faure ha scritto: The thing I wonder is... does it really make sense to have a model with random ordering? Isn't it a problem for users if their visible list of places is different between every run? Or am I missing something and the different order in the test isn't

Re: KFilePlacesModelTest

2016-05-07 Thread Michael Pyne
On Sat, May 7, 2016 14:33:53 David Faure wrote: > The thing I wonder is... does it really make sense to have a model with > random ordering? Isn't it a problem for users if their visible list of > places is different between every run? Or am I missing something and the > different order in the test

Re: KFilePlacesModelTest

2016-05-07 Thread Kevin Ottens
Hello, Not sure I can be of any help anymore in that area, I've been way to remote from that code for years now. That said there's a couple of questions at the end I might be able to answer: On Saturday, 7 May 2016 14:33:53 CEST David Faure wrote: > The thing I wonder is... does it really make

Re: KFilePlacesModelTest

2016-05-07 Thread David Faure
On Saturday 07 May 2016 19:03:17 Giuseppe D'Angelo wrote: > Il 07/05/2016 14:33, David Faure ha scritto: > > The thing I wonder is... does it really make sense to have a model with > > random ordering? > > Isn't it a problem for users if their visible list of places is different > > between every

Re: KFilePlacesModelTest

2016-05-07 Thread David Faure
On Wednesday 08 July 2015 07:58:22 Kevin Ottens wrote: > > On Saturday 04 July 2015 22:24:50 David Faure wrote: > > CI says: > > > > 10:59:57 QDEBUG : KFilePlacesModelTest::testReparse() Expected: > > ("/home/jenkins", "remote:/", "/", "trash:/", "/media/nfs", "/foreign", > > "/media/XO-Y4", "/me

Re: KFilePlacesModelTest

2015-07-07 Thread Kevin Ottens
Hello, On Saturday 04 July 2015 22:24:50 David Faure wrote: > CI says: > > 10:59:57 QDEBUG : KFilePlacesModelTest::testReparse() Expected: > ("/home/jenkins", "remote:/", "/", "trash:/", "/media/nfs", "/foreign", > "/media/XO-Y4", "/media/floppy0", "/media/cdrom", "/foo") 10:59:57 QDEBUG : > KFil