Re: KCoreAddons forward headers

2013-12-30 Thread David Faure
On Monday 30 December 2013 14:59:51 Aleix Pol wrote: > It only has the lowercase headers, uppercase headers are installed from > another command: > install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/KCoreAddons DESTINATION > ${INCLUDE_INSTALL_DIR} COMPONENT Devel ) Ah, right. Sounds good to me as it

Re: KCoreAddons forward headers

2013-12-30 Thread Aleix Pol
On Mon, Dec 30, 2013 at 11:42 AM, David Faure wrote: > On Monday 30 December 2013 01:26:52 Aleix Pol wrote: > > On Sun, Dec 29, 2013 at 8:10 PM, David Faure wrote: > > > On Sunday 29 December 2013 16:18:23 Christoph Cullmann wrote: > > > > > On Friday 27 December 2013 19:36:57 Aleix Pol wrote: >

Re: KCoreAddons forward headers

2013-12-30 Thread David Faure
On Monday 30 December 2013 01:26:52 Aleix Pol wrote: > On Sun, Dec 29, 2013 at 8:10 PM, David Faure wrote: > > On Sunday 29 December 2013 16:18:23 Christoph Cullmann wrote: > > > > On Friday 27 December 2013 19:36:57 Aleix Pol wrote: > > > > > Hi, > > > > > Here's a patch adding CamelCase headers

Re: KCoreAddons forward headers

2013-12-30 Thread Alex Merry
On 30/12/13 00:26, Aleix Pol wrote: > No, it creates a variable called KCoreAddons_HEADERS which is passed to > the install() command. ECM_GENERATE_HEADERS doesn't install anything, we > decided to do it like that to minimize the magic factor. > > Please take a look at the function documentation,

Re: KCoreAddons forward headers

2013-12-29 Thread Aleix Pol
On Sun, Dec 29, 2013 at 8:10 PM, David Faure wrote: > On Sunday 29 December 2013 16:18:23 Christoph Cullmann wrote: > > > On Friday 27 December 2013 19:36:57 Aleix Pol wrote: > > > > Hi, > > > > Here's a patch adding CamelCase headers to KCoreAddons (attached). > > > > > > > > If we agree that it

Re: KCoreAddons forward headers

2013-12-29 Thread David Faure
On Sunday 29 December 2013 16:18:23 Christoph Cullmann wrote: > > On Friday 27 December 2013 19:36:57 Aleix Pol wrote: > > > Hi, > > > Here's a patch adding CamelCase headers to KCoreAddons (attached). > > > > > > If we agree that it's the proper way of doing it, I'll proceed to do it > > > on > >

Re: KCoreAddons forward headers

2013-12-29 Thread Christoph Cullmann
> On Friday 27 December 2013 19:36:57 Aleix Pol wrote: > > Hi, > > Here's a patch adding CamelCase headers to KCoreAddons (attached). > > > > If we agree that it's the proper way of doing it, I'll proceed to do it on > > the rest of modules. > > Looks good to me. I like the fact that we can't for

Re: KCoreAddons forward headers

2013-12-29 Thread David Faure
On Friday 27 December 2013 19:36:57 Aleix Pol wrote: > Hi, > Here's a patch adding CamelCase headers to KCoreAddons (attached). > > If we agree that it's the proper way of doing it, I'll proceed to do it on > the rest of modules. Looks good to me. I like the fact that we can't forget to add forwa