Re: KFileItem (Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #982)

2013-08-23 Thread Frank Reininghaus
Hi, 2013/8/22 David Faure: > On Thursday 08 August 2013 13:17:18 Frank Reininghaus wrote: >> Hi David, >> >> 2013/8/7 David Faure: >> > On Tuesday 06 August 2013 20:53:05 Frank Reininghaus wrote: >> >> OK, I see now that it uses pointers to be able to modify the actual >> >> KFileItems in KDirList

Re: KFileItem (Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #982)

2013-08-22 Thread David Faure
On Thursday 08 August 2013 13:17:18 Frank Reininghaus wrote: > Hi David, > > 2013/8/7 David Faure: > > On Tuesday 06 August 2013 20:53:05 Frank Reininghaus wrote: > >> OK, I see now that it uses pointers to be able to modify the actual > >> KFileItems in KDirListerCache (if it would just keep KFil

Re: KFileItem (Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #982)

2013-08-08 Thread Frank Reininghaus
Hi David, 2013/8/7 David Faure: > On Tuesday 06 August 2013 20:53:05 Frank Reininghaus wrote: >> OK, I see now that it uses pointers to be able to modify the actual >> KFileItems in KDirListerCache (if it would just keep KFileItems and >> modify these, I guess that they would just detach from the

KFileItem (Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #982)

2013-08-07 Thread David Faure
On Tuesday 06 August 2013 20:53:05 Frank Reininghaus wrote: > OK, I see now that it uses pointers to be able to modify the actual > KFileItems in KDirListerCache (if it would just keep KFileItems and > modify these, I guess that they would just detach from the ones inside > the cache, leaving those

Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #982

2013-08-06 Thread Frank Reininghaus
Hi, 2013/8/6 Frank Reininghaus: > Hi, > > 2013/8/6 KDE CI System : >> See > > the crash in KDirListerTest has been caused by my recent change > > https://git.reviewboard.kde.org/r/111789/ > > First of all, I apologize for not having run

Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #982

2013-08-06 Thread Frank Reininghaus
Hi, 2013/8/6 KDE CI System : > See the crash in KDirListerTest has been caused by my recent change https://git.reviewboard.kde.org/r/111789/ First of all, I apologize for not having run that test before. I had thought that running KF