Re: Dependency specifications

2013-09-15 Thread Alexander Neundorf
On Sunday 15 September 2013, Aleix Pol wrote: > On Sat, Sep 14, 2013 at 7:42 PM, Stephen Kelly wrote: > > Aleix Pol wrote: > > > I'd say that all Qt dependencies in the module should be defined only > > > > once > > > > > in the root CMakeLists.txt. Actually this should be the only file with > >

Re: Dependency specifications

2013-09-14 Thread Aleix Pol
On Sat, Sep 14, 2013 at 7:42 PM, Stephen Kelly wrote: > Aleix Pol wrote: > > > I'd say that all Qt dependencies in the module should be defined only > once > > in the root CMakeLists.txt. Actually this should be the only file with > > "find_package" calls. > > > > Why? What is the problem with ha

Re: Dependency specifications

2013-09-14 Thread Stephen Kelly
Aleix Pol wrote: > I'd say that all Qt dependencies in the module should be defined only once > in the root CMakeLists.txt. Actually this should be the only file with > "find_package" calls. > Why? What is the problem with having a find_package in src? Thanks, Steve.

Re: Dependency specifications

2013-09-14 Thread Michael Palimaka
On 12/09/2013 10:32, Aleix Pol wrote: I'd say that all Qt dependencies in the module should be defined only once in the root CMakeLists.txt. Actually this should be the only file with "find_package" calls. At a high level, that sounds reasonable, but I don't think this is necessarily the best so

Re: Dependency specifications

2013-09-13 Thread David Faure
On Friday 13 September 2013 13:17:47 Aleix Pol wrote: > Well, but in that case you'll maybe want to find QtGui, QtWidgets or > KF5::AwesomeTests. Ah yes, true, manual tests can have more deps sometimes. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Fra

Re: Dependency specifications

2013-09-13 Thread Aleix Pol
On Fri, Sep 13, 2013 at 1:17 PM, David Faure wrote: > On Friday 13 September 2013 13:03:29 Aleix Pol wrote: > > On Fri, Sep 13, 2013 at 9:43 AM, David Faure wrote: > > > On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: > > > > I'd say that all Qt dependencies in the module should be defin

Re: Dependency specifications

2013-09-13 Thread David Faure
On Friday 13 September 2013 13:03:29 Aleix Pol wrote: > On Fri, Sep 13, 2013 at 9:43 AM, David Faure wrote: > > On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: > > > I'd say that all Qt dependencies in the module should be defined only > > > > once > > > > > in the root CMakeLists.txt. A

Re: Dependency specifications

2013-09-13 Thread Aleix Pol
On Fri, Sep 13, 2013 at 9:43 AM, David Faure wrote: > On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: > > I'd say that all Qt dependencies in the module should be defined only > once > > in the root CMakeLists.txt. Actually this should be the only file with > > "find_package" calls. > > A

Re: Dependency specifications

2013-09-13 Thread David Faure
On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: > I'd say that all Qt dependencies in the module should be defined only once > in the root CMakeLists.txt. Actually this should be the only file with > "find_package" calls. And I disagree. If you build the framework with unittests disabled (

Re: Dependency specifications

2013-09-11 Thread Aleix Pol
On Tue, Sep 10, 2013 at 7:42 PM, Michael Palimaka wrote: > Hi, > > Currently, the specification for Qt dependencies is not always consistent > between tier1 frameworks. > > In particular, I notice dependencies being specified twice (eg. QtTest in > both project root and in autotests), and test dep