Re: Qt5 cmake stuff

2012-05-15 Thread Stephen Kelly
Alexander Neundorf wrote: > On Monday 14 May 2012, David Faure wrote: >> On Monday 14 May 2012 23:13:44 Alexander Neundorf wrote: >> > if (NOT TARGET Qt5::Core) >> > >> > add_library(Qt5::Core SHARED IMPORTED) >> > >> > endif() >> >> Thanks, that works, and is MUCH simpler too ;-) >> >> Any

Re: Qt5 cmake stuff

2012-05-14 Thread David Faure
On Monday 14 May 2012 23:32:10 Alexander Neundorf wrote: > On Monday 14 May 2012, David Faure wrote: > > On Monday 14 May 2012 23:22:09 Alexander Neundorf wrote: > > > On Monday 14 May 2012, Alexander Neundorf wrote: > > > ... > > > > > > > For now, you can change the code e.g. to > > > > if (NOT

Re: Qt5 cmake stuff

2012-05-14 Thread Alexander Neundorf
On Monday 14 May 2012, David Faure wrote: > On Monday 14 May 2012 23:22:09 Alexander Neundorf wrote: > > On Monday 14 May 2012, Alexander Neundorf wrote: > > ... > > > > > For now, you can change the code e.g. to > > > if (NOT TARGET Qt5::Core) > > > > > > message(STATUS "DF: Qt5CoreConfig.cmak

Re: Qt5 cmake stuff

2012-05-14 Thread Alexander Neundorf
On Monday 14 May 2012, David Faure wrote: > On Monday 14 May 2012 23:13:44 Alexander Neundorf wrote: > > if (NOT TARGET Qt5::Core) > > > > add_library(Qt5::Core SHARED IMPORTED) > > > > endif() > > Thanks, that works, and is MUCH simpler too ;-) > > Any reason against committing that upstream

Re: Qt5 cmake stuff

2012-05-14 Thread David Faure
On Monday 14 May 2012 23:22:09 Alexander Neundorf wrote: > On Monday 14 May 2012, Alexander Neundorf wrote: > ... > > > For now, you can change the code e.g. to > > if (NOT TARGET Qt5::Core) > > > > message(STATUS "DF: Qt5CoreConfig.cmake add_library(Qt5::Core)") > > add_library(Qt5::Core SHA

Re: Qt5 cmake stuff

2012-05-14 Thread Alexander Neundorf
On Monday 14 May 2012, Alexander Neundorf wrote: ... > For now, you can change the code e.g. to > if (NOT TARGET Qt5::Core) > message(STATUS "DF: Qt5CoreConfig.cmake add_library(Qt5::Core)") > add_library(Qt5::Core SHARED IMPORTED) > endif() > > OR > > if (NOT _qt5CoreTargetExists) > set(_Q

Re: Qt5 cmake stuff

2012-05-14 Thread David Faure
On Monday 14 May 2012 23:13:44 Alexander Neundorf wrote: > if (NOT TARGET Qt5::Core) > add_library(Qt5::Core SHARED IMPORTED) > endif() Thanks, that works, and is MUCH simpler too ;-) Any reason against committing that upstream? Requires a too recent cmake? -- David Faure, fa...@kde.org, http

Re: Qt5 cmake stuff

2012-05-14 Thread Alexander Neundorf
On Monday 14 May 2012, Alexander Neundorf wrote: > On Monday 14 May 2012, David Faure wrote: > > On Monday 14 May 2012 18:10:19 David Faure wrote: > > > Hi (Steve), > > > > > > It seems that updating Qt5 to the latest master broke my > > > kdelibs-frameworks-qt5 build? > > > > > > CMake Error at

Re: Qt5 cmake stuff

2012-05-14 Thread David Faure
On Monday 14 May 2012 23:05:01 Alexander Neundorf wrote: > On Monday 14 May 2012, David Faure wrote: > > On Monday 14 May 2012 18:10:19 David Faure wrote: > > > Hi (Steve), > > > > > > It seems that updating Qt5 to the latest master broke my > > > kdelibs-frameworks-qt5 build? > > > > > > CMake E

Re: Qt5 cmake stuff

2012-05-14 Thread Alexander Neundorf
On Monday 14 May 2012, David Faure wrote: > On Monday 14 May 2012 18:10:19 David Faure wrote: > > Hi (Steve), > > > > It seems that updating Qt5 to the latest master broke my > > kdelibs-frameworks-qt5 build? > > > > CMake Error at > > /d/qt/5/qtbase-master/lib/cmake/Qt5Core/Qt5CoreConfig.cmake:6

Re: Qt5 cmake stuff

2012-05-14 Thread David Faure
On Monday 14 May 2012 18:10:19 David Faure wrote: > Hi (Steve), > > It seems that updating Qt5 to the latest master broke my > kdelibs-frameworks-qt5 build? > > CMake Error at > /d/qt/5/qtbase-master/lib/cmake/Qt5Core/Qt5CoreConfig.cmake:60 > (add_library): add_library cannot create imported targ

Qt5 cmake stuff

2012-05-14 Thread David Faure
Hi (Steve), It seems that updating Qt5 to the latest master broke my kdelibs-frameworks-qt5 build? CMake Error at /d/qt/5/qtbase-master/lib/cmake/Qt5Core/Qt5CoreConfig.cmake:60 (add_library): add_library cannot create imported target "Qt5::Core" because another target with the same name alr